Bug 217721

Summary: Non-unified build fixes, mid October 2020
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, cdumez, changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, keith_miller, kondapallykalyan, mark.lam, mmaxfield, msaboff, pdr, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 217734    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Don Olmstead 2020-10-14 11:51:22 PDT
It's close to midnight
And something evil's lurking in the dark
Under the moonlight
You see a sight that almost stops your heart

You try to scream
But terror takes the sound before you make it
You start to freeze
As horror looks you right between the eyes
You're paralyzed

'Cause this is thriller, thriller night
And no one's gonna save you from the beast about to strike
You know it's thriller, thriller night
You're fighting for your life inside a killer thriller tonight, yeah
Comment 1 Don Olmstead 2020-10-14 12:10:37 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2020-10-14 12:14:01 PDT
Created attachment 411359 [details]
Patch
Comment 3 Yusuke Suzuki 2020-10-14 12:16:17 PDT
Comment on attachment 411359 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411359&action=review

One comment, the other part looks good to me!

> Source/JavaScriptCore/API/JSContextRef.cpp:37
>  #include "JSObject.h"

Let's remove `"JSObject.h"` since "JSObjectInlines.h" is included.
Comment 4 Don Olmstead 2020-10-14 12:25:24 PDT
Created attachment 411365 [details]
Patch
Comment 5 EWS 2020-10-14 13:46:37 PDT
Committed r268485: <https://trac.webkit.org/changeset/268485>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411365 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-14 13:47:19 PDT
<rdar://problem/70306689>