Bug 217705

Summary: MediaRecorder .stop should not throw in Inactive state
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, clopez, darin, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/web-platform-tests/wpt/pull/26114
Attachments:
Description Flags
Patch none

Description youenn fablet 2020-10-14 05:57:20 PDT 
MediaRecorder .stop should not throw in Inactive state
Comment 1 youenn fablet 2020-10-14 05:57:59 PDT 
See https://github.com/w3c/mediacapture-record/pull/158
Comment 2 youenn fablet 2020-10-14 06:00:11 PDT 
Created attachment 411316 [details]
Patch
Comment 3 youenn fablet 2020-10-14 06:01:01 PDT 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/26114
Comment 4 EWS Watchlist 2020-10-14 06:01:04 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 EWS 2020-10-14 11:56:09 PDT 
Committed r268477: <https://trac.webkit.org/changeset/268477>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411316 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-14 11:57:25 PDT 
<rdar://problem/70302371>
Comment 7 Darin Adler 2020-10-18 12:51:00 PDT 
Comment on attachment 411316 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411316&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:216
> -    return { };
> +    return;

Should just delete this.