Bug 217663

Summary: WebAudio tests are crashing in debug when enabling the GPU process
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2020-10-13 12:12:55 PDT
WebAudio tests are crashing in debug when enabling the GPU process because it does audio processing on the WebContent process' main thread.
Attachments
Patch (37.62 KB, patch)
2020-10-13 12:30 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (38.36 KB, patch)
2020-10-13 12:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.36 KB, patch)
2020-10-13 12:54 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.36 KB, patch)
2020-10-13 13:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (38.59 KB, patch)
2020-10-13 13:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-10-13 12:30:47 PDT
Created attachment 411237 [details] Patch
Chris Dumez
Comment 2 2020-10-13 12:39:44 PDT
Created attachment 411238 [details] Patch
Chris Dumez
Comment 3 2020-10-13 12:54:27 PDT
Created attachment 411240 [details] Patch
Geoffrey Garen
Comment 4 2020-10-13 13:19:56 PDT
Comment on attachment 411240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411240&action=review r=me > Source/WTF/ChangeLog:13 > + deque (since the queue is empty). dequeue > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:115 > + audioBus->setChannelMemory(i, (float*)buffers[i]->data(), framesToProcess); static_cast<float*>
Chris Dumez
Comment 5 2020-10-13 13:24:32 PDT
Created attachment 411245 [details] Patch
Peng Liu
Comment 6 2020-10-13 13:32:38 PDT
Comment on attachment 411245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411245&action=review > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:46 > +constexpr size_t fifoSize = 96 * WebCore::AudioUtilities::renderQuantumSize; Could you explain how did you choose the number 96? Thanks! > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:87 > void render(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess, const WebCore::AudioIOPosition& outputPosition) override Nit. Looks like "sourceBus" is not used? > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:140 > + WebCore::PushPullFIFO m_fifo; I like this change!
Chris Dumez
Comment 7 2020-10-13 13:33:48 PDT
(In reply to Peng Liu from comment #6) > Comment on attachment 411245 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411245&action=review > > > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:46 > > +constexpr size_t fifoSize = 96 * WebCore::AudioUtilities::renderQuantumSize; > > Could you explain how did you choose the number 96? Thanks! Oh, I used the same size as the fifo queue in AudioDestinationCocoa.mm. I will add a comment. > > > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:87 > > void render(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess, const WebCore::AudioIOPosition& outputPosition) override > > Nit. Looks like "sourceBus" is not used? > > > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:140 > > + WebCore::PushPullFIFO m_fifo; > > I like this change!
Chris Dumez
Comment 8 2020-10-13 13:36:24 PDT
Created attachment 411247 [details] Patch
EWS
Comment 9 2020-10-13 14:53:27 PDT
Committed r268423: <https://trac.webkit.org/changeset/268423> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411247 [details].
Radar WebKit Bug Importer
Comment 10 2020-10-13 14:54:18 PDT
<rdar://problem/70267708>
Note You need to log in before you can comment on or make changes to this bug.