| Summary: | WebAudio tests are crashing in debug when enabling the GPU process | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||
| Component: | Web Audio | Assignee: | Chris Dumez <cdumez> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, eric.carlson, ews-watchlist, ggaren, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, ryuan.choi, sergio, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Chris Dumez
2020-10-13 12:12:55 PDT
Created attachment 411237 [details]
Patch
Created attachment 411238 [details]
Patch
Created attachment 411240 [details]
Patch
Comment on attachment 411240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411240&action=review r=me > Source/WTF/ChangeLog:13 > + deque (since the queue is empty). dequeue > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:115 > + audioBus->setChannelMemory(i, (float*)buffers[i]->data(), framesToProcess); static_cast<float*> Created attachment 411245 [details]
Patch
Comment on attachment 411245 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411245&action=review > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:46 > +constexpr size_t fifoSize = 96 * WebCore::AudioUtilities::renderQuantumSize; Could you explain how did you choose the number 96? Thanks! > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:87 > void render(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess, const WebCore::AudioIOPosition& outputPosition) override Nit. Looks like "sourceBus" is not used? > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:140 > + WebCore::PushPullFIFO m_fifo; I like this change! (In reply to Peng Liu from comment #6) > Comment on attachment 411245 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=411245&action=review > > > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:46 > > +constexpr size_t fifoSize = 96 * WebCore::AudioUtilities::renderQuantumSize; > > Could you explain how did you choose the number 96? Thanks! Oh, I used the same size as the fifo queue in AudioDestinationCocoa.mm. I will add a comment. > > > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:87 > > void render(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess, const WebCore::AudioIOPosition& outputPosition) override > > Nit. Looks like "sourceBus" is not used? > > > Source/WebKit/GPUProcess/media/RemoteAudioDestinationManager.cpp:140 > > + WebCore::PushPullFIFO m_fifo; > > I like this change! Created attachment 411247 [details]
Patch
Committed r268423: <https://trac.webkit.org/changeset/268423> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411247 [details]. |