| Summary: | Clean up the API tests of CARingBuffer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||
| Component: | New Bugs | Assignee: | Peng Liu <peng.liu6> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Peng Liu
2020-10-12 14:15:59 PDT
Created attachment 411157 [details]
Patch
Comment on attachment 411157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review > Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28 > +#if PLATFORM(COCOA) Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead? Comment on attachment 411157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411157&action=review >> Tools/TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:28 >> +#if PLATFORM(COCOA) > > Maybe HAVE(CORE_AUDIO) or HAVE(AUDIO_TOOLBOX) instead? Yes, good point! Thanks! Created attachment 411176 [details]
Revise the patch according to Sam's comment
Committed r268397: <https://trac.webkit.org/changeset/268397> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411176 [details]. |