| Summary: | CSSStyleDeclaration includes descriptors | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Sneddon [:gsnedders] <gsnedders> | ||||
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | emilio, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, joepeck, koivisto, macpherson, menard, sam, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=217623 | ||||||
| Attachments: |
|
||||||
If you want more to fix around CSSStyleDeclaration Sam, there's more :) CSS.supports gets this right, but the IDL generation doesn't. Sam, can you point me to where the difference between properties and descriptors is defined? Our current CSSProperties.json does not seem to differentiate (or I don't understand how it is), so I would need a better understanding of what to change. Sam, I filed https://github.com/w3c/csswg-drafts/issues/5633 about the fact that this is pretty unclear currently. A bunch of these have "skip-builder": true currently, so maybe we just want that more? (In reply to Sam Sneddon [:gsnedders] from comment #3) > Sam, I filed https://github.com/w3c/csswg-drafts/issues/5633 about the fact > that this is pretty unclear currently. > > A bunch of these have "skip-builder": true currently, so maybe we just want > that more? There are ~40 marked with "skip-builder". If that is the set, perhaps we can rename skip-builder to be something semantic about the property rather than an action and use it, but I am not clear if that is the correct set. Created attachment 412038 [details]
Patch
Turns out there was a function on CSSProperty called isDescriptorOnly, so I'm going to use that as the guide. Hm, seems at least on rest expects some descriptors sometimes. The test, imported/w3c/web-platform-tests/css/cssom/cssom-fontfacerule.html, seems to indicate that when you get a CSSStyleDeclaration from a CSSFontFaceRule, it should include the descriptor "src". Reseting to default assignee while we work out what the behavior here should really be. (In reply to Sam Weinig from comment #9) > The test, imported/w3c/web-platform-tests/css/cssom/cssom-fontfacerule.html, > seems to indicate that when you get a CSSStyleDeclaration from a > CSSFontFaceRule, it should include the descriptor "src". (In reply to Sam Weinig from comment #10) > Reseting to default assignee while we work out what the behavior here should > really be. See also: https://github.com/w3c/csswg-drafts/issues/5649 |
e.g.: > "unicode-range" in document.body.style < true CSSStyleDeclaration should just contain properties, not descriptors.