Bug 217573

Summary: [GPU Process][Resource caching 5/7]: Clean the DisplayList recording of the NativeImage
Product: WebKit Reporter: Said Abou-Hallawa <sabouhallawa>
Component: Layout and RenderingAssignee: Said Abou-Hallawa <sabouhallawa>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, calvaris, cdumez, cgarcia, eric.carlson, ews-watchlist, glenn, gustavo, gyuyoung.kim, japhet, jer.noble, menard, philipj, pnormand, ryuan.choi, sergio, simon.fraser, vjaquez, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217566    
Bug Blocks: 217342, 217596    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for review
none
Patch
ews-feeder: commit-queue-
Patch none

Said Abou-Hallawa
Reported 2020-10-11 01:44:41 PDT
-- Move the definition of NativeImagePtr to a separate header file. -- Remove the class ImageHandle and allow encoding and decoding NativeImagePtr directly. -- Remove the compilation directives around the DisplayList::DrawNativeImage item and the method drawNativeImage(). -- Move the drawNativeImage() methods to the sources of their callers. -- In the case of recording the drawing commands, make GraphicsContext::drawImage() process drawing the images such that primitives drawing commands are recorded. For example a BitmapImage will render a NativeImage eventually. And SVGImage will record its render tree.
Attachments
Patch (169.38 KB, patch)
2020-10-11 01:46 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (170.26 KB, patch)
2020-10-11 01:55 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (46.57 KB, patch)
2020-10-11 03:01 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (49.40 KB, patch)
2020-10-17 01:48 PDT, Said Abou-Hallawa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (49.98 KB, patch)
2020-10-17 02:25 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2020-10-11 01:46:45 PDT
Created attachment 411041 [details] Patch
Said Abou-Hallawa
Comment 2 2020-10-11 01:55:19 PDT
Created attachment 411042 [details] Patch
Said Abou-Hallawa
Comment 3 2020-10-11 03:01:24 PDT
Created attachment 411044 [details] Patch for review
Said Abou-Hallawa
Comment 4 2020-10-17 01:48:22 PDT
Created attachment 411660 [details] Patch
Said Abou-Hallawa
Comment 5 2020-10-17 02:25:21 PDT
Created attachment 411662 [details] Patch
Simon Fraser (smfr)
Comment 6 2020-10-17 11:05:08 PDT
Comment on attachment 411662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411662&action=review > Source/WebCore/platform/graphics/BitmapImage.cpp:218 > + // Subsampling may have given us an image that is smaller than size(). > + IntSize subsampledImageSize = nativeImageSize(image); > + if (options.orientation().usesWidthAsHeight()) > + subsampledImageSize = subsampledImageSize.transposedSize(); > + > + // srcRect is in the coordinates of the unsubsampled image, so we have to map it to the subsampled image. > + FloatRect adjustedSrcRect = srcRect; > + if (subsampledImageSize != srcSize) > + adjustedSrcRect = mapRect(srcRect, FloatRect({ }, srcSize), FloatRect({ }, subsampledImageSize)); What justifies this code being here and not inside GraphicsContext::drawNativeImage?
Radar WebKit Bug Importer
Comment 7 2020-10-18 01:45:14 PDT
<rdar://problem/70415273>
Said Abou-Hallawa
Comment 8 2020-10-19 09:34:49 PDT
Comment on attachment 411662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411662&action=review >> Source/WebCore/platform/graphics/BitmapImage.cpp:218 >> + adjustedSrcRect = mapRect(srcRect, FloatRect({ }, srcSize), FloatRect({ }, subsampledImageSize)); > > What justifies this code being here and not inside GraphicsContext::drawNativeImage? I will move this code to GraphicsContext::drawNativeImage() in bug 217596.
EWS
Comment 9 2020-10-19 09:49:05 PDT
Committed r268669: <https://trac.webkit.org/changeset/268669> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411662 [details].
Note You need to log in before you can comment on or make changes to this bug.