| Summary: | [GPU Process] Mechanical cleanup in DisplayListRecorder | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | sam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 217506 | ||||||||
| Attachments: |
|
||||||||
|
Description
Myles C. Maxfield
2020-10-09 16:13:00 PDT
Created attachment 410980 [details]
Patch
Comment on attachment 410980 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410980&action=review > Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:381 > + DrawingItem& newItem = downcast<DrawingItem>(appendItem(WTFMove(item))); > + updateItemExtent(newItem); auto would good here. If you wanted to, I would also consider making Recorder::appendItem a template function so that the downcast is not needed for callers of appendItem. template<typename ItemType> ItemType& Recorder::appendItem(Ref<ItemType>&& item) { willAppendItem(item.get()); return downcast<ItemType>(m_displayList.append(WTFMove(item))); } Created attachment 410982 [details]
Patch for committing
Committed r268300: <https://trac.webkit.org/changeset/268300> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410982 [details]. |