| Summary: | [Media in GPU Process] Enable audio routing arbitration on Mac | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||
| Component: | Media | Assignee: | Peng Liu <peng.liu6> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Peng Liu
2020-10-09 12:58:22 PDT
Created attachment 410965 [details]
Patch
Comment on attachment 410965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410965&action=review > Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:78 > +#elif PLATFORM(MAC) > + AudioSession::setCategory(type, policy); > +#else Please add a FIXME here and reference the bug that will move AudioSessionRoutingArbitratorProxy to the GPU process. Created attachment 410973 [details]
Patch for landing
Comment on attachment 410965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410965&action=review >> Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp:78 >> +#else > > Please add a FIXME here and reference the bug that will move AudioSessionRoutingArbitratorProxy to the GPU process. Done! Filed webkit.org/b/217535 to track that. Thanks! Committed r268292: <https://trac.webkit.org/changeset/268292> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410973 [details]. |