Bug 217508

Summary:

Implement TCC checks in UserMediaPermissionRequestManagerProxy

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebRTC

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none

Description youenn fablet 2020-10-09 00:52:44 PDT

Implement TCC checks in UserMediaPermissionRequestManagerProxy

Comment 1 Radar WebKit Bug Importer 2020-10-09 00:53:02 PDT

<rdar://problem/70129993>

Comment 2 youenn fablet 2020-10-09 01:05:36 PDT

Created attachment 410923 [details]
Patch

Comment 3 youenn fablet 2020-10-09 01:29:02 PDT

Created attachment 410924 [details]
Patch

Comment 4 youenn fablet 2020-10-09 05:18:48 PDT

Created attachment 410935 [details]
Patch

Comment 5 Eric Carlson 2020-10-09 07:00:57 PDT

Comment on attachment 410935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410935&action=review

> Source/WebKit/UIProcess/Cocoa/UserMediaPermissionRequestManagerProxy.mm:155
> +    auto completionHandler = requiresVideoTCCPrompt ? [request = makeRef(request), callback = WTFMove(callback)](bool isOK) mutable {
> +        if (!isOK) {
> +            callback(false);
> +            return;
> +        }
> +        requestAVCaptureAccessForMediaType(WTFMove(callback), AVMediaTypeVideo);
> +    } : WTFMove(callback);

Very nice!

Comment 6 EWS 2020-10-09 07:06:28 PDT

Committed r268256: <https://trac.webkit.org/changeset/268256>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410935 [details].