Bug 217507

Summary: [WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped since r260174
Product: WebKit Reporter: Fujii Hironori <Hironori.Fujii>
Component: PlatformAssignee: Fujii Hironori <Hironori.Fujii>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, don.olmstead, ews-watchlist, kondapallykalyan, luiz, noam, ross.kirsling, tomoki.imai, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Fujii Hironori 2020-10-09 00:29:28 PDT
[WinCairo][GraphicsLayerTextureMapper] Image layers are entirely clipped since r260174

For example, compositing/images/content-image.html shows no image.

Some images aren't shown in http://www.satine.org/research/webkit/snowleopard/snowstack.html
Comment 1 Fujii Hironori 2020-10-09 00:30:51 PDT
since r260174
Bug 210544 – TextureMapper renders video element with "object-fit: cover" incorrectly
Comment 2 Fujii Hironori 2020-10-09 00:43:33 PDT
Created attachment 410921 [details]
Patch
Comment 3 Tomoki Imai 2020-10-09 02:08:52 PDT
(In reply to Fujii Hironori from comment #2)
> Created attachment 410921 [details]
> Patch

Thanks Fujii -san for the patch, and sorry for making a regression in WinCairo.
The change looks good to me, but I'd like to ask Ross, Don to review and r+ in case.
Comment 4 Fujii Hironori 2020-10-09 12:51:25 PDT
Comment on attachment 410921 [details]
Patch

Clearing flags on attachment: 410921

Committed r268280: <https://trac.webkit.org/changeset/268280>
Comment 5 Fujii Hironori 2020-10-09 12:51:29 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-10-09 12:52:18 PDT
<rdar://problem/70149429>