| Summary: | Move some audio buffer management related files from folder "mac" to folder "cocoa" | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Peng Liu <peng.liu6> | ||||||||||
| Component: | Media | Assignee: | Peng Liu <peng.liu6> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Peng Liu
2020-10-08 16:04:49 PDT
Created attachment 410893 [details]
Patch
Created attachment 410902 [details]
Patch
Created attachment 410904 [details]
Patch
Created attachment 410905 [details]
Patch
Comment on attachment 410905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410905&action=review > Source/WebCore/platform/audio/cocoa/CAAudioStreamDescription.hSource/WebCore/platform/audio/mac/CAAudioStreamDescription.h:69 > + AudioStreamBasicDescription& streamDescription(); Why not keeping them inline. If not with the declaration, we can keep them as inline in the header. Comment on attachment 410905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410905&action=review >> Source/WebCore/platform/audio/cocoa/CAAudioStreamDescription.hSource/WebCore/platform/audio/mac/CAAudioStreamDescription.h:69 >> + AudioStreamBasicDescription& streamDescription(); > > Why not keeping them inline. > If not with the declaration, we can keep them as inline in the header. We already have WEBCORE_EXPORT on the class, so the style checker will complain if we keep them as inline. Committed r268266: <https://trac.webkit.org/changeset/268266> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410905 [details]. |