Bug 217483

Summary: [macOS] Issue sandbox extension for icon service when attachment element is enabled
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Per Arne Vollan 2020-10-08 10:33:46 PDT 
This has previously been done on iOS, and should be done on macOS as well.
Comment 1 Radar WebKit Bug Importer 2020-10-08 10:34:33 PDT 
<rdar://problem/70099680>
Comment 2 Per Arne Vollan 2020-10-08 12:45:01 PDT 
Created attachment 410873 [details]
Patch
Comment 3 Per Arne Vollan 2020-10-08 12:53:50 PDT 
Created attachment 410874 [details]
Patch
Comment 4 Per Arne Vollan 2020-10-08 13:01:13 PDT 
Created attachment 410875 [details]
Patch
Comment 5 Brent Fulgham 2020-10-09 10:52:27 PDT 
Comment on attachment 410875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410875&action=review

Nice harmonizing of the two platforms. r=me

> Source/WebKit/Shared/WebPageCreationParameters.cpp:328
> +#endif

Oh, oops!

> Source/WebKit/UIProcess/WebProcessProxy.h:-364
> -#if ENABLE(ATTACHMENT_ELEMENT) && PLATFORM(IOS_FAMILY)

Nice when everything is in sync!
Comment 6 Per Arne Vollan 2020-10-09 10:54:06 PDT 
Comment on attachment 410875 [details]
Patch

Thanks for reviewing!
Comment 7 EWS 2020-10-09 11:07:52 PDT 
Committed r268270: <https://trac.webkit.org/changeset/268270>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410875 [details].