Bug 217469

Summary: Improve serialization of scroll-snap-type
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217467    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Martin Robinson 2020-10-08 03:21:24 PDT 
Since the default value for the second part of scroll-snap-type is "proximity" it should serialize to an empty string. This will fix a couple scroll snapping tests from the WPT suite.
Comment 1 Martin Robinson 2020-10-09 02:08:56 PDT 
Created attachment 410925 [details]
Patch
Comment 2 Martin Robinson 2020-10-09 04:36:02 PDT 
Created attachment 410930 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-10-09 09:33:38 PDT 
Comment on attachment 410930 [details]
Patch

Still one test failure.
Comment 4 Martin Robinson 2020-10-12 01:08:20 PDT 
Created attachment 411101 [details]
Patch
Comment 5 EWS 2020-10-12 01:46:01 PDT 
Committed r268348: <https://trac.webkit.org/changeset/268348>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 411101 [details].
Comment 6 Radar WebKit Bug Importer 2020-10-12 01:47:18 PDT 
<rdar://problem/70198259>