Bug 217460

Summary: [JSC] Restrict more ptr-tagging and avoid using OperationPtrTag for JIT code
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 217502    
Bug Blocks:    
Attachments:
Description Flags
Patch saam: review+

Description Yusuke Suzuki 2020-10-07 18:12:47 PDT 
[JSC] Restrict more ptr-tagging and avoid using OperationPtrTag for JIT code
Comment 1 Yusuke Suzuki 2020-10-07 18:16:42 PDT 
Created attachment 410806 [details]
Patch
Comment 2 Mark Lam 2020-10-07 18:49:16 PDT 
Comment on attachment 410806 [details]
Patch

r=me too.  As per offline conversation, please remove extra () around callTarget in LLINT_CALL_END_IMPL, and use a new PtrValuePtrTag for m_putFunction in PutPropertySlot and re-sign as needed.
Comment 3 Yusuke Suzuki 2020-10-07 21:19:05 PDT 
Committed r268170: <https://trac.webkit.org/changeset/268170>
Comment 4 Radar WebKit Bug Importer 2020-10-07 21:20:22 PDT 
<rdar://problem/70078652>
Comment 5 Yusuke Suzuki 2020-10-08 10:56:59 PDT 
Committed r268190: <https://trac.webkit.org/changeset/268190>
Comment 6 WebKit Commit Bot 2020-10-08 18:16:49 PDT 
Re-opened since this is blocked by bug 217502
Comment 7 Yusuke Suzuki 2020-10-08 22:08:23 PDT 
Committed r268247: <https://trac.webkit.org/changeset/268247>