| Summary: | [LFC][BFC] Move document box special height computation out of contentHeightForFormattingContextRoot | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2020-10-06 13:21:53 PDT
Created attachment 410687 [details]
Patch
Comment on attachment 410687 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410687&action=review > Source/WebCore/layout/FormattingContextGeometry.cpp:826 > + else if (layoutBox.isDocumentBox() && !layoutBox.establishesFormattingContext()) { isDocumentElementBox (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 410687 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410687&action=review > > > Source/WebCore/layout/FormattingContextGeometry.cpp:826 > > + else if (layoutBox.isDocumentBox() && !layoutBox.establishesFormattingContext()) { > > isDocumentElementBox Make sense. Will rename it in a separate patch. Committed r268082: <https://trac.webkit.org/changeset/268082> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410687 [details]. |