Bug 217393

Summary: REGRESSION: [Mac Release] 2 Cookie API are failing
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description Truitt Savell 2020-10-06 10:36:55 PDT 
TestWebKitAPI.WebKit.CookieCacheSyncAcrossProcess
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:110
        Expected equality of these values:
          "foo=bar"
          (NSString *)cookie
            Which is: ""
        
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:130
        Expected equality of these values:
          "foo=bar"
          cookieString
            Which is: ""
        

    TestWebKitAPI.WebKit.RelaxThirdPartyCookieBlocking
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:232
        Value of: strstr(request.data(), "Cookie: a=b\r\n")
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:232
        Value of: strstr(request.data(), "Cookie: a=b\r\n")
          Actual: false
        Expected: true
        
        
        /Volumes/Data/slave/catalina-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:232
        Value of: strstr(request.data(), "Cookie: a=b\r\n")
          Actual: false
        Expected: true
Comment 1 Radar WebKit Bug Importer 2020-10-06 10:37:16 PDT 
<rdar://problem/70006475>
Comment 2 Alex Christensen 2020-10-09 10:46:28 PDT 
Created attachment 410950 [details]
Patch
Comment 3 Alex Christensen 2020-10-09 11:06:23 PDT 
Created attachment 410952 [details]
Patch
Comment 4 Chris Dumez 2020-10-09 11:28:05 PDT 
Comment on attachment 410952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410952&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:81
> +    [[WKWebsiteDataStore defaultDataStore].httpCookieStore _setCookieAcceptPolicy:static_cast<NSHTTPCookieAcceptPolicy>(NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain) completionHandler:^{

This test does not use the default data store at all. It uses an ephemeral session so why does setting the default data store cookie policy help? Doesn't this indicate a WebKit bug of some sort?
Comment 5 Alex Christensen 2020-10-09 12:01:24 PDT 
Comment on attachment 410952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410952&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:81
>> +    [[WKWebsiteDataStore defaultDataStore].httpCookieStore _setCookieAcceptPolicy:static_cast<NSHTTPCookieAcceptPolicy>(NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain) completionHandler:^{
> 
> This test does not use the default data store at all. It uses an ephemeral session so why does setting the default data store cookie policy help? Doesn't this indicate a WebKit bug of some sort?

CFNetwork ephemeral cookie stores inherit their initial cookie accept policy from the default store.
Comment 6 Alex Christensen 2020-10-09 12:31:22 PDT 
Created attachment 410964 [details]
Patch
Comment 7 EWS 2020-10-09 13:53:55 PDT 
Committed r268286: <https://trac.webkit.org/changeset/268286>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410964 [details].