| Summary: | Add support for MediaRecorder bitrate getters | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, jer.noble, kondapallykalyan, philipj, sergio, webkit-bug-importer, youennf | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Local Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
youenn fablet
2020-10-06 06:43:52 PDT
Created attachment 410630 [details]
Patch
Created attachment 410817 [details]
Patch
Created attachment 410820 [details]
Patch
Comment on attachment 410820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104 > + options.audioBitsPerSecond = 192000; Where do these numbers come from? (In reply to Alex Christensen from comment #4) > Comment on attachment 410820 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410820&action=review > > > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104 > > + options.audioBitsPerSecond = 192000; > > Where do these numbers come from? The spec says to choose decent defaults. These are values for quality recording of audio and video. They could be set lower. Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome. Comment on attachment 410820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410820&action=review >>> Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:104 >>> + options.audioBitsPerSecond = 192000; >> >> Where do these numbers come from? > > The spec says to choose decent defaults. > These are values for quality recording of audio and video. > They could be set lower. > > Firefox is using 128kbps/2.5mbps which is not too far. Not sure about Chrome. It might be helpful for someone looking at this later to have a named constant. > Source/WebCore/platform/mediarecorder/MediaRecorderPrivate.cpp:106 > + options.videoBitsPerSecond = 10000000; Ditto Created attachment 410936 [details]
Patch for landing
commit-queue failed to commit attachment 410936 [details] to WebKit repository.
Committed r268363: <https://trac.webkit.org/changeset/268363> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410936 [details]. |