Bug 217380

Summary:

REGRESSION(r267399): [WPE] Build broken with ENABLE_ACCESSIBILITY=OFF

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Tools / Tests

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cgarcia, clopez, don.olmstead, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2020-10-06 05:17:54 PDT

CMake will fail with the following error when passing -DENABLE_ACCESSIBILITY=OFF:

-- Enabled features:
--  ENABLE_ACCELERATED_2D_CANVAS .................. ON
--  ENABLE_ACCESSIBILITY                            OFF
--  ENABLE_BUBBLEWRAP_SANDBOX ..................... OFF                                                                
--  ENABLE_ENCRYPTED_MEDIA                          OFF
--  ENABLE_GTKDOC ................................. OFF
--  ENABLE_MEDIA_SOURCE                             ON
--  ENABLE_SHAREABLE_RESOURCE ..................... ON
--  ENABLE_VIDEO                                    ON                                                                 
--  ENABLE_WEBDRIVER .............................. OFF
--  ENABLE_WEB_AUDIO                                ON
--  ENABLE_WEB_CRYPTO ............................. ON
--  ENABLE_WPE_QT_API                               OFF
--  ENABLE_XSLT ................................... ON
--  USE_OPENJPEG                                    ON
--  USE_SYSTEMD ................................... ON
--  USE_WOFF2                                       ON
-- Configuring done
CMake Error at Source/cmake/WebKitMacros.cmake:143 (add_executable):
  Target "WebProcess" links to target "ATK::Bridge" but the target was not
  found.  Perhaps a find_package() call is missing for an IMPORTED target, or
  an ALIAS target is missing?
Call Stack (most recent call first):
  Source/WebKit/CMakeLists.txt:377 (WEBKIT_EXECUTABLE_DECLARE)

Comment 1 Adrian Perez 2020-10-06 05:28:10 PDT

The issue was introduced in r267399 / bug #216773

Comment 2 Adrian Perez 2020-10-06 05:36:28 PDT

Created attachment 410626 [details]
Patch

Comment 3 EWS 2020-10-06 06:23:54 PDT

Committed r268046: <https://trac.webkit.org/changeset/268046>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410626 [details].

Comment 4 Radar WebKit Bug Importer 2020-10-06 06:24:16 PDT

<rdar://problem/69996942>