Bug 217374

Summary: Mac: Remove OpenGL and OpenGL ES backends
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, annulen, cdumez, changseok, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, koivisto, kondapallykalyan, noam, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Mac   
OS: All   
Bug Depends on:    
Bug Blocks: 217213    
Attachments:
Description Flags
Patch
none
Patch none

Kimmo Kinnunen
Reported 2020-10-06 03:51:03 PDT
Remove OpenGL (CGL) and OpenGL ES (EAGL) backends. Make ANGLE the only backend. Current layering violations and technical dept makes it too laboursome to implement the blocking bugs.
Attachments
Patch (148.00 KB, patch)
2020-10-07 05:25 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch (148.27 KB, patch)
2020-10-08 02:00 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2020-10-07 05:25:02 PDT
Created attachment 410745 [details] Patch
Darin Adler
Comment 2 2020-10-07 08:06:53 PDT
Comment on attachment 410745 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410745&action=review Looks great. > Source/WebCore/platform/graphics/GraphicsContextGL.h:780 > + Should not leave this extra blank line. > Source/WebCore/platform/graphics/cocoa/WebGLLayer.h:38 > + Should not add this extra blank line here. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:52 > +namespace { We mostly still use static rather than anonymous namespace for this kind of thing in WebKit. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:53 > +// TODO: Fix style to allow multi-line raw strings. Not an important follow-up so I would omit this comment. Also. WebKit usies FIXME, not TODO. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:54 > +#define SHADER(text) #text##_s Why do we need this macro at all? It does not seem to add any helpful abstraction. > Source/WebCore/platform/graphics/cv/VideoTextureCopierCV.cpp:56 > +const ASCIILiteral s_rgbVertexShader { SHADER( constexpr auto or static constexpr auto?
Dean Jackson
Comment 3 2020-10-07 09:42:51 PDT
Comment on attachment 410745 [details] Patch Awesome!
Kimmo Kinnunen
Comment 4 2020-10-08 02:00:10 PDT
Created attachment 410819 [details] Patch
EWS
Comment 5 2020-10-08 11:56:50 PDT
Committed r268198: <https://trac.webkit.org/changeset/268198> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410819 [details].
Radar WebKit Bug Importer
Comment 6 2020-10-08 11:57:29 PDT
<rdar://problem/70103808>
Alex Christensen
Comment 7 2020-10-08 17:14:30 PDT
Has this day really finally come? Exciting!
Note You need to log in before you can comment on or make changes to this bug.