Bug 217356

Summary: MobileSafari crashes at WebCore: -[WebAVPlayerViewControllerDelegate playerViewControllerWillStartPictureInPicture:]
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: New BugsAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ddkilzer, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
achristensen: review+, ews-feeder: commit-queue-
Patch for landing none

Description Peng Liu 2020-10-05 17:45:27 PDT 
MobileSafari crashes at WebCore: -[WebAVPlayerViewControllerDelegate playerViewControllerWillStartPictureInPicture:]
Comment 1 Peng Liu 2020-10-05 17:49:33 PDT 
<rdar://66987917>
Comment 2 Peng Liu 2020-10-05 17:53:56 PDT 
Created attachment 410596 [details]
Patch
Comment 3 Alex Christensen 2020-10-05 18:48:24 PDT 
Comment on attachment 410596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410596&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:181
>  }

else 
    return YES;
Comment 4 Peng Liu 2020-10-05 19:30:28 PDT 
Comment on attachment 410596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410596&action=review

>> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:181
>>  }
> 
> else 
>     return YES;

Yes! Will fix it. Thanks!
Comment 5 Peng Liu 2020-10-05 20:20:04 PDT 
Created attachment 410604 [details]
Patch for landing
Comment 6 EWS 2020-10-05 22:32:21 PDT 
Committed r268035: <https://trac.webkit.org/changeset/268035>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410604 [details].