| Summary: | Make value parameter in Document.execCommand non nullable | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Rob Buis <rbuis> | ||||||||
| Component: | DOM | Assignee: | Rob Buis <rbuis> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, darin, esprehn+autocc, ews-watchlist, kangil.han, kondapallykalyan, mifenton, sam, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rob Buis
2020-10-05 13:18:29 PDT
Created attachment 410547 [details]
Patch
Comment on attachment 410547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review > Source/WebCore/dom/Document+HTML.idl:71 > + [CEReactions] boolean execCommand(DOMString commandId, optional boolean showUI = false, optional DOMString value = null); I think the default value is supposed to be "". Are you planning to fix that in a follow up? If you wanted to, you could just do them all at one. Created attachment 410616 [details]
Patch
Created attachment 410618 [details]
Patch
Committed r268043: <https://trac.webkit.org/changeset/268043> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410618 [details]. Comment on attachment 410547 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410547&action=review > LayoutTests/editing/execCommand/arguments-combinations-expected.txt:10 > +PASS <hr id="null"> is <hr id="null"> Nice how poor the output from this test is, no clue of what's being tested. We should come back to this and rearrange the test so the output is useful. (In reply to Darin Adler from comment #7) > Nice how poor the output from this test is, no clue of what's being tested. > We should come back to this and rearrange the test so the output is useful. *Notice*, not *Nice*. |