Bug 217312

Summary: MediaRecorder should respect enabled and muted tracks
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description youenn fablet 2020-10-05 08:17:00 PDT
MediaRecorder should respect enabled and muted tracks
Comment 1 youenn fablet 2020-10-05 08:20:26 PDT
Created attachment 410515 [details]
Patch
Comment 2 youenn fablet 2020-10-05 08:55:14 PDT
Created attachment 410524 [details]
Patch
Comment 3 Eric Carlson 2020-10-05 09:50:26 PDT
Comment on attachment 410524 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410524&action=review

> Source/WebCore/ChangeLog:8
> +        If track is muted, replace it by either silence (audio buffer filled with zero) or black frames.

s/zero/zeros/
Comment 4 youenn fablet 2020-10-05 11:15:34 PDT
Created attachment 410533 [details]
Patch for landing
Comment 5 Radar WebKit Bug Importer 2020-10-05 11:16:47 PDT
<rdar://problem/69962663>
Comment 6 EWS 2020-10-05 11:52:36 PDT
Committed r267987: <https://trac.webkit.org/changeset/267987>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410533 [details].