| Summary: | Simplify and harden idl_files.tmp generation | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | darin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Sam Weinig
2020-10-02 13:43:26 PDT
Created attachment 410363 [details]
Patch
We don't have to actually remove the delete, but I don't see the benefit in keeping it either. Comment on attachment 410363 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410363&action=review > Source/WebCore/DerivedSources.make:1774 > + $(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > idl_files.tmp) Why not name the file something like JSBindingIDLs.txt instead of idl_files.tmp? Created attachment 410367 [details]
Patch
(In reply to Darin Adler from comment #3) > Comment on attachment 410363 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410363&action=review > > > Source/WebCore/DerivedSources.make:1774 > > + $(shell echo $(JS_BINDING_IDLS) | tr " " "\n" > idl_files.tmp) > > Why not name the file something like JSBindingIDLs.txt instead of > idl_files.tmp? Indeed. Committed r267928: <https://trac.webkit.org/changeset/267928> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410367 [details]. |