| Summary: | Web Inspector: Uncaught Exception: TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true') | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, hi, inspector-bugzilla-changes, katherine_cheney, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
Created attachment 410351 [details]
Patch
Comment on attachment 410351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review > Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 > - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); Why remove this call? Comment on attachment 410351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review >> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 >> - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); > > Why remove this call? this is done later inside `_handleEventBreakpointDisabledStateChanged` (which is an event listener callback for `WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by `WI.Breakpoint.prototype.set disabled`) (In reply to Devin Rousso from comment #3) > Comment on attachment 410351 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410351&action=review > > >> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 > >> - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); > > > > Why remove this call? > > this is done later inside `_handleEventBreakpointDisabledStateChanged` > (which is an event listener callback for > `WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by > `WI.Breakpoint.prototype.set disabled`) Nice, thanks for explaining! Comment on attachment 410351 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410351&action=review r=e >>>> Source/WebInspectorUI/UserInterface/Controllers/DOMManager.js:-701 >>>> - target.DOMAgent.removeBreakpointForEventListener(eventListener.eventListenerId); >>> >>> Why remove this call? >> >> this is done later inside `_handleEventBreakpointDisabledStateChanged` (which is an event listener callback for `WI.Breakpoint.Event.DisabledStateDidChange`, which is dispatched by `WI.Breakpoint.prototype.set disabled`) > > Nice, thanks for explaining! Would have been good to put this in the changelog :-) r=me * Committed r267998: <https://trac.webkit.org/changeset/267998> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410351 [details]. |
# STEPS TO REPRODUCE 1. inspect any page with JS event listeners 2. uncheck the "Enabled" checkbox for any event listener on any node Uncaught Exceptions: ----------------------- - TypeError: undefined is not an object (evaluating 'breakpoint.disabled = true') (at DOMManager.js:705:19) removeBreakpointForEventListener @ DOMManager.js:705:19 hasEventListenerBreakpoint @ EventListenerSectionGroup.js:167:59 ? @ EventListenerSectionGroup.js:62:25