| Summary: | WebDriver: start a https server too for tests | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebDriver | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, bburg, ews-watchlist, glenn, jbedard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 166679 | ||||||
| Attachments: |
|
||||||
Created attachment 411849 [details]
Patch
Comment on attachment 411849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=411849&action=review > Tools/ChangeLog:9 > + Handle HTTPS configuration in WebDriver WTP server. Typo: WTP → WPT. > Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:98 > + config['doc_root'] = doc_root Much nicer to modify the data structure than blindly replacing %DOC_ROOT% =) Committed r268723: <https://trac.webkit.org/changeset/268723> |
It's required for some cookie tests: imported/w3c/webdriver/tests/get_named_cookie/get.py::test_get_cookie_with_same_site_flag[capabilities0-None] imported/w3c/webdriver/tests/get_named_cookie/get.py::test_get_cookie_with_same_site_flag[capabilities0-Lax] imported/w3c/webdriver/tests/get_named_cookie/get.py::test_get_cookie_with_same_site_flag[capabilities0-Strict] def inner(path, protocol="http", domain="", subdomain="", query="", fragment=""): domain = server_config["domains"][domain][subdomain] > port = server_config["ports"][protocol][0] E KeyError: 'https'