| Summary: | [GTK] WPE and backend versions are mixed up in webkit://gpu | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alice Mikhaylenko <alicem> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aperez, berto, bugs-noreply, cgarcia, ews-watchlist, gustavo | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alice Mikhaylenko
2020-10-02 04:10:02 PDT
Created attachment 410310 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Sorry, I always forget that webkit-patch upload doesn't set commit-queue? by default. (In reply to Alexander Mikhaylenko from comment #3) > Sorry, I always forget that webkit-patch upload doesn't set commit-queue? by > default. No problem, I've now done the cq+ bit. You can use “webkit-patch upload --request-commit” to have the script set cq? by itself. Unfortunately setting cq? is not the default 😶️ Committed r267875: <https://trac.webkit.org/changeset/267875> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410310 [details]. |