| Summary: | [WebIDL] Add support for non-nullable optional wrapper type arguments to operations | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, esprehn+autocc, ews-watchlist, kondapallykalyan, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 219165 | ||||||||||||
| Bug Blocks: | 171589 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Sam Weinig
2020-09-30 19:37:32 PDT
Created attachment 410197 [details]
Patch
Created attachment 410241 [details]
Patch
Comment on attachment 410241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410241&action=review > LayoutTests/ChangeLog:12 > +2020-09-30 Sam Weinig <weinig@apple.com> double changelog. (In reply to Chris Dumez from comment #3) > Comment on attachment 410241 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410241&action=review > > > LayoutTests/ChangeLog:12 > > +2020-09-30 Sam Weinig <weinig@apple.com> > > double changelog. No really close to ready for review yet. Just using the bots to build things for me while my computer is busy :). (In reply to Sam Weinig from comment #4) > (In reply to Chris Dumez from comment #3) > > Comment on attachment 410241 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=410241&action=review > > > > > LayoutTests/ChangeLog:12 > > > +2020-09-30 Sam Weinig <weinig@apple.com> > > > > double changelog. > > No really close to ready for review yet. Just using the bots to build things > for me while my computer is busy :). Yeah but I got curious and could not help but look :P (In reply to Chris Dumez from comment #5) > (In reply to Sam Weinig from comment #4) > > (In reply to Chris Dumez from comment #3) > > > Comment on attachment 410241 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=410241&action=review > > > > > > > LayoutTests/ChangeLog:12 > > > > +2020-09-30 Sam Weinig <weinig@apple.com> > > > > > > double changelog. > > > > No really close to ready for review yet. Just using the bots to build things > > for me while my computer is busy :). > > Yeah but I got curious and could not help but look :P It was good, I probably would have missed it :). Created attachment 410246 [details]
Patch
I think it should be ready for review now. Comment on attachment 410246 [details]
Patch
r=me
Re-running Mac-wk2 EWS since I think the failing test is unrelated. Created attachment 410293 [details]
Patch
Committed r267865: <https://trac.webkit.org/changeset/267865> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410293 [details]. Comment on attachment 410293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410293&action=review > Source/WebCore/Modules/geolocation/Geolocation.idl:-35 > - optional PositionErrorCallback? errorCallback, I don't think we should have made those changes. Those parameters are nullable in both Firefox and Chrome. Also, there are WPT tests that fail unless this parameter is nullable. I am planning on reverting the changes to Geolocation.idl as a result. |