Bug 217110

Summary: Expose pvrtc extension without vendor prefix and remove redundant WebGL 2 extensions
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: WebGLAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, kbr, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126404    
Attachments:
Description Flags
Patch
none
Patch none

James Darpinian
Reported 2020-09-29 16:51:16 PDT
Expose pvrtc extension without vendor prefix and remove redundant WebGL 2 extensions
Attachments
Patch (8.72 KB, patch)
2020-09-29 16:52 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Patch (10.55 KB, patch)
2020-09-30 16:27 PDT, James Darpinian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-09-29 16:52:29 PDT
Created attachment 410067 [details] Patch
Kenneth Russell
Comment 2 2020-09-29 16:59:20 PDT
Comment on attachment 410067 [details] Patch Looks good to me assuming you've tested these changes locally with the associated extension tests; if an extension spontaneously stops getting supported then the current layout tests won't catch that, and will still pass. r+
EWS
Comment 3 2020-09-29 19:06:51 PDT
Found 1 new test failure: webgl/2.0.0/conformance2/extensions/promoted-extensions.html
James Darpinian
Comment 4 2020-09-30 16:27:48 PDT
Created attachment 410169 [details] Patch
EWS
Comment 5 2020-09-30 17:01:40 PDT
Committed r267811: <https://trac.webkit.org/changeset/267811> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410169 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-30 17:02:19 PDT
<rdar://problem/69814976>
Note You need to log in before you can comment on or make changes to this bug.