| Summary: | [WebIDL] Make Exposed mandatory for IDL interfaces | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
| Component: | Bindings | Assignee: | Sam Weinig <sam> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, calvaris, cdumez, changseok, cmarcelo, darin, dbarton, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, graouts, gyuyoung.kim, hi, hta, japhet, jer.noble, jiewen_tan, kangil.han, kondapallykalyan, macpherson, menard, mifenton, mmaxfield, pdr, philipj, sabouhallawa, schenney, sergio, tommyw, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Sam Weinig
2020-09-29 13:21:26 PDT
Created attachment 410157 [details]
Patch
Comment on attachment 410157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410157&action=review > Source/WebCore/Modules/applepay/ApplePaySetup.idl:31 > SecureContext, > + Exposed=Window Looks like the existing ones above are sorted alphabetically, but this new one is not. Comment on attachment 410157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410157&action=review >> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31 >> + Exposed=Window > > Looks like the existing ones above are sorted alphabetically, but this new one is not. Many other cases like this. (In reply to Darin Adler from comment #3) > Comment on attachment 410157 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410157&action=review > > >> Source/WebCore/Modules/applepay/ApplePaySetup.idl:31 > >> + Exposed=Window > > > > Looks like the existing ones above are sorted alphabetically, but this new one is not. > > Many other cases like this. I'm going to write a script to check this (like I just did with the preferences) or just make the parser enforce it. Committed r267813: <https://trac.webkit.org/changeset/267813> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410157 [details]. |