| Summary: | Modify END_AX_OBJC_EXCEPTIONS macro to assert to aid debugging of layout tests. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cfleizach, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andres Gonzalez
2020-09-29 11:12:51 PDT
Created attachment 410024 [details]
Patch
Comment on attachment 410024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=410024&action=review > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38 > + ASSERT_NOT_REACHED(); \ if we're going to assert here, do we even need to do anything else? (In reply to chris fleizach from comment #2) > Comment on attachment 410024 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=410024&action=review > > > Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:38 > > + ASSERT_NOT_REACHED(); \ > > if we're going to assert here, do we even need to do anything else? The original intention is to re-throw the exceptions that are not NSAccessibilityExceptions. So I wouldn't want to change that behavior in release builds in case someone/something depends on it. Committed r267774: <https://trac.webkit.org/changeset/267774> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410024 [details]. |