Bug 217088

Summary: Re-align DocumentAndElementEventHandlers.idl, GlobalEventHandlers.idl and WindowEventHandlers.idl with the HTML spec
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, dbarton, dino, esprehn+autocc, ews-watchlist, fmalita, fred.wang, gyuyoung.kim, kangil.han, kondapallykalyan, pdr, sabouhallawa, schenney, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Sam Weinig 2020-09-29 08:56:03 PDT
Re-align DocumentAndElementEventHandlers.idl, GlobalEventHandlers.idl and WindowEventHandlers.idl with the HTML spec
Comment 1 Sam Weinig 2020-09-29 08:57:23 PDT
Created attachment 410006 [details]
Patch
Comment 2 Sam Weinig 2020-09-29 18:23:45 PDT
Created attachment 410080 [details]
Patch
Comment 3 Darin Adler 2020-09-29 18:53:05 PDT
Comment on attachment 410080 [details]
Patch

Seems like you could have added more of these and not left them commented out. Typically they do no harm if they are simply listening to events we don’t dispatch, as long as they are not somehow used for feature detection.
Comment 4 Sam Weinig 2020-09-30 08:25:52 PDT
Created attachment 410123 [details]
Patch
Comment 5 EWS 2020-09-30 09:04:21 PDT
Committed r267791: <https://trac.webkit.org/changeset/267791>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410123 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-30 09:05:26 PDT
<rdar://problem/69793800>