Bug 217073

Summary: [macCatalyst] Focus rings are not painted
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, changseok, cmarcelo, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Safari Technology Preview   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Aditya Keerthi 2020-09-28 18:29:07 PDT 
...
Comment 1 Aditya Keerthi 2020-09-28 18:29:28 PDT 
<rdar://problem/46794111>
Comment 2 Aditya Keerthi 2020-09-28 18:41:24 PDT 
Created attachment 409943 [details]
Patch
Comment 3 Tim Horton 2020-09-28 18:45:57 PDT 
Should see what Wenson thinks about watchOS.
Comment 4 Tim Horton 2020-09-28 18:46:36 PDT 
Might need to give this its own enable that is on for MAC, IOS, and MACCATALYST, but not the others.
Comment 5 Aditya Keerthi 2020-09-28 19:26:19 PDT 
Created attachment 409951 [details]
Patch
Comment 6 Wenson Hsieh 2020-09-28 19:37:51 PDT 
(In reply to Tim Horton from comment #3)
> Should see what Wenson thinks about watchOS.

I think it should be fine to match iPhone behavior for watchOS and tvOS.
Comment 7 Tim Horton 2020-09-28 21:04:00 PDT 
(In reply to Wenson Hsieh from comment #6)
> (In reply to Tim Horton from comment #3)
> > Should see what Wenson thinks about watchOS.
> 
> I think it should be fine to match iPhone behavior for watchOS and tvOS.

Except that apparently the UIKit API is missing!
Comment 8 Wenson Hsieh 2020-09-28 22:46:33 PDT 
(In reply to Tim Horton from comment #7)
> (In reply to Wenson Hsieh from comment #6)
> > (In reply to Tim Horton from comment #3)
> > > Should see what Wenson thinks about watchOS.
> > 
> > I think it should be fine to match iPhone behavior for watchOS and tvOS.
> 
> Except that apparently the UIKit API is missing!

Ah, I see. I take that back, then!
Comment 9 Aditya Keerthi 2020-09-29 07:50:57 PDT 
Created attachment 409998 [details]
Patch
Comment 10 Aditya Keerthi 2020-09-29 07:52:14 PDT 
(In reply to Tim Horton from comment #7)
> (In reply to Wenson Hsieh from comment #6)
> > (In reply to Tim Horton from comment #3)
> > > Should see what Wenson thinks about watchOS.
> > 
> > I think it should be fine to match iPhone behavior for watchOS and tvOS.
> 
> Except that apparently the UIKit API is missing!

I think the API is available, just forgot to remove the flags from UIKitSPI.h.
Comment 11 Tim Horton 2020-09-29 13:49:11 PDT 
(In reply to Aditya Keerthi from comment #10)
> (In reply to Tim Horton from comment #7)
> > (In reply to Wenson Hsieh from comment #6)
> > > (In reply to Tim Horton from comment #3)
> > > > Should see what Wenson thinks about watchOS.
> > > 
> > > I think it should be fine to match iPhone behavior for watchOS and tvOS.
> > 
> > Except that apparently the UIKit API is missing!
> 
> I think the API is available, just forgot to remove the flags from
> UIKitSPI.h.

Ah!
Comment 12 EWS 2020-09-29 14:22:35 PDT 
Committed r267760: <https://trac.webkit.org/changeset/267760>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409998 [details].