| Summary: | Add WKContentWorld declarations required by _WKUserStyleSheet | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saagar Jha <saagar> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | darin, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saagar Jha
2020-09-28 18:17:14 PDT
Created attachment 409940 [details]
Patch
Comment on attachment 409940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409940&action=review > Source/WebKit/ChangeLog:12 > + _WKUserStyleSheet uses WKContentWorld, but doesn't import it specifically. In the unified > + build, _WKUserContentWorld.mm (which transitively includes the header that defines > + WKContentWorld) is listed two lines above _WKUserStyleSheet.mm, which often means that this > + issue gets hidden if the split occurs such that they end up in the same compilation unit. > + This change should allow the build to work regardless of whether the files end up together. > + > + Add WKContentWorld declarations required by _WKUserStyleSheet > + https://bugs.webkit.org/show_bug.cgi?id=217072 > + > + Reviewed by NOBODY (OOPS!). Your changelog is not quite in the right order! Look at other examples; it goes Title Bug Reviewed By Description File List Created attachment 410664 [details]
Patch
OOPS! Here's a new patch; thanks for catching that :) |