Bug 217072

Summary: Add WKContentWorld declarations required by _WKUserStyleSheet
Product: WebKit Reporter: Saagar Jha <saagar>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: darin, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Saagar Jha
Reported 2020-09-28 18:17:14 PDT
Add WKContentWorld declarations required by _WKUserStyleSheet
Attachments
Patch (2.30 KB, patch)
2020-09-28 18:36 PDT, Saagar Jha 		no flags
DetailsFormatted DiffDiff
Patch (2.25 KB, patch)
2020-10-06 11:14 PDT, Saagar Jha 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Saagar Jha
Comment 1 2020-09-28 18:36:14 PDT
Created attachment 409940 [details] Patch
Radar WebKit Bug Importer
Comment 2 2020-10-05 18:18:15 PDT
<rdar://problem/69980010>
Tim Horton
Comment 3 2020-10-06 11:05:21 PDT
Comment on attachment 409940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409940&action=review > Source/WebKit/ChangeLog:12 > + _WKUserStyleSheet uses WKContentWorld, but doesn't import it specifically. In the unified > + build, _WKUserContentWorld.mm (which transitively includes the header that defines > + WKContentWorld) is listed two lines above _WKUserStyleSheet.mm, which often means that this > + issue gets hidden if the split occurs such that they end up in the same compilation unit. > + This change should allow the build to work regardless of whether the files end up together. > + > + Add WKContentWorld declarations required by _WKUserStyleSheet > + https://bugs.webkit.org/show_bug.cgi?id=217072 > + > + Reviewed by NOBODY (OOPS!). Your changelog is not quite in the right order! Look at other examples; it goes Title Bug Reviewed By Description File List
Saagar Jha
Comment 4 2020-10-06 11:14:37 PDT
Created attachment 410664 [details] Patch
Saagar Jha
Comment 5 2020-10-06 11:15:27 PDT
OOPS! Here's a new patch; thanks for catching that :)
Note You need to log in before you can comment on or make changes to this bug.