| Summary: | Fix test failures inadventently introduced in r267644 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Angelos Oikonomopoulos <angelos> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aperez, darin, keith_miller, mark.lam, ross.kirsling, saam, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Angelos Oikonomopoulos
2020-09-28 03:20:45 PDT
Created attachment 409878 [details]
Patch
Created attachment 409881 [details]
Patch
Committed r267696: <https://trac.webkit.org/changeset/267696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409881 [details]. Comment on attachment 409881 [details]
Patch
It doesn’t make sense that these would lead to test failures. The test tool would strip the spaces. These scripts would not be able to detect that the spaces were stripped. Did tests really fail? How?
Oh, I think I understand. These were broken when they were run, not with DumpRenderTree or WebKitTestRunner, but in some other JavaScript-only way. (In reply to Darin Adler from comment #6) > Oh, I think I understand. These were broken when they were run, not with > DumpRenderTree or WebKitTestRunner, but in some other JavaScript-only way. Right, those are getting run by run-jsc-stress-tests. |