Bug 217028

Summary: Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms
Product: WebKit Reporter: Darin Adler <darin>
Component: Tools / TestsAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ews-watchlist, keith_miller, mark.lam, msaboff, saam, sam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch sam: review+

Description Darin Adler 2020-09-26 22:21:33 PDT 
Refactor test runner code to cut down on copy/paste code and long-winded repetitive idioms
Comment 1 Darin Adler 2020-09-27 11:46:40 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2020-09-27 11:47:06 PDT 
Not setting review? yet because I must have made at least one mistake in all the global replaces and refactoring.
Comment 3 Darin Adler 2020-09-27 11:51:48 PDT Comment hidden (obsolete)
Comment 4 Darin Adler 2020-09-27 11:57:09 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2020-09-27 12:44:44 PDT Comment hidden (obsolete)
Comment 6 Darin Adler 2020-09-27 12:50:39 PDT Comment hidden (obsolete)
Comment 7 Darin Adler 2020-09-27 12:55:13 PDT Comment hidden (obsolete)
Comment 8 Darin Adler 2020-09-27 15:02:47 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2020-09-27 18:46:52 PDT Comment hidden (obsolete)
Comment 10 Darin Adler 2020-09-27 18:55:49 PDT Comment hidden (obsolete)
Comment 11 Darin Adler 2020-09-27 21:47:45 PDT Comment hidden (obsolete)
Comment 12 Darin Adler 2020-09-27 23:06:47 PDT Comment hidden (obsolete)
Comment 13 Darin Adler 2020-09-28 09:57:13 PDT Comment hidden (obsolete)
Comment 14 Darin Adler 2020-09-28 19:35:47 PDT 
Created attachment 409952 [details]
Patch
Comment 15 Darin Adler 2020-09-29 13:12:12 PDT 
Working now, so ready for review.
Comment 16 Sam Weinig 2020-09-29 14:15:06 PDT 
Comment on attachment 409952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409952&action=review

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:96
> +static JSContextRef mainJSContext()

I would prefer this be called mainFrameJSContext, just because main on its own is so ambiguous, but I feel this in a very minor way.
Comment 17 Darin Adler 2020-09-29 14:39:03 PDT 
Committed r267761: <https://trac.webkit.org/changeset/267761>
Comment 18 Radar WebKit Bug Importer 2020-09-29 14:40:22 PDT 
<rdar://problem/69764444>