Bug 217008

Summary: Test bug for code review timeouts
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: ASSIGNED    
Severity: Normal CC: cdumez, changseok, dino, esprehn+autocc, ews-watchlist, graouts, gyuyoung.kim, jarhar, kondapallykalyan, masonf, richard.townsend, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
kbr: review?
test patch
none
test patch upload 2
none
test patch upload 3
none
test patch 4
none
test
none
test
none
test
none
test
none
test
none
test none

Kenneth Russell
Reported 2020-09-25 21:39:30 PDT
This is a test bug for diagnosing timeouts with the code review tool when using Chrome - crbug.com/1132508 .
Attachments
Patch (4.63 KB, patch)
2020-09-25 21:40 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2020-09-28 10:08 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2020-09-28 10:09 PDT, Kenneth Russell 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2020-09-28 10:17 PDT, Kenneth Russell 		kbr: review?
DetailsFormatted DiffDiff
test patch (4.63 KB, patch)
2020-09-28 17:45 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test patch upload 2 (4.63 KB, patch)
2020-09-28 17:46 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test patch upload 3 (4.63 KB, patch)
2020-09-28 17:46 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test patch 4 (4.63 KB, patch)
2020-10-09 20:17 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test (4.63 KB, patch)
2020-10-10 12:01 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test (4.63 KB, patch)
2020-10-12 08:54 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test (4.63 KB, patch)
2020-10-13 13:29 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test (4.63 KB, patch)
2020-10-13 15:25 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test (4.63 KB, patch)
2020-10-13 16:33 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
test (4.63 KB, patch)
2020-10-13 17:30 PDT, Joey Arhar 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2020-09-25 21:40:17 PDT
Created attachment 409769 [details] Patch
Kenneth Russell
Comment 2 2020-09-28 10:08:16 PDT
Created attachment 409894 [details] Patch
Kenneth Russell
Comment 3 2020-09-28 10:09:57 PDT
Created attachment 409895 [details] Patch
Kenneth Russell
Comment 4 2020-09-28 10:17:36 PDT
Created attachment 409897 [details] Patch
Joey Arhar
Comment 5 2020-09-28 17:45:27 PDT
Created attachment 409932 [details] test patch
Joey Arhar
Comment 6 2020-09-28 17:46:02 PDT
Created attachment 409933 [details] test patch upload 2
Joey Arhar
Comment 7 2020-09-28 17:46:24 PDT
Created attachment 409934 [details] test patch upload 3
Joey Arhar
Comment 8 2020-09-28 17:47:05 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:10 > + * html/canvas/WebGLRenderingContextBase.cpp: test comment 1
Joey Arhar
Comment 9 2020-09-28 17:47:28 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::WebGLRenderingContextBase::initializeNewContext): test comment 2
Joey Arhar
Comment 10 2020-09-28 17:47:47 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:12 > + (WebCore::WebGLRenderingContextBase::bindAttribLocation): test comment 3
Joey Arhar
Comment 11 2020-09-28 17:48:06 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::WebGLRenderingContextBase::createFramebuffer): test comment 4
Joey Arhar
Comment 12 2020-09-28 17:48:16 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::WebGLRenderingContextBase::drawArrays): test comment 5
Joey Arhar
Comment 13 2020-09-28 17:49:18 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::WebGLRenderingContextBase::getUniformLocation): test comment 6
Joey Arhar
Comment 14 2020-09-28 17:49:46 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::WebGLRenderingContextBase::getUniformLocation): test comment 6
Joey Arhar
Comment 15 2020-09-28 17:51:25 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::WebGLRenderingContextBase::readPixels): test comment 7
Joey Arhar
Comment 16 2020-09-28 17:51:40 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::WebGLRenderingContextBase::texSubImage2DBase): test comment 8
Joey Arhar
Comment 17 2020-09-28 17:53:20 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:18 > + (WebCore::WebGLRenderingContextBase::texParameter): test comment 9
Joey Arhar
Comment 18 2020-09-28 17:53:33 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:19 > + test comment 10
Joey Arhar
Comment 19 2020-09-28 17:54:32 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:20 > 2020-09-23 Chris Dumez <cdumez@apple.com> test comment 11
Joey Arhar
Comment 20 2020-09-28 17:54:42 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:21 > test comment 12
Joey Arhar
Comment 21 2020-09-28 17:55:23 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/ChangeLog:22 > webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing test comment 13
Joey Arhar
Comment 22 2020-09-28 17:55:35 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844 > test comment 14
Joey Arhar
Comment 23 2020-09-28 17:56:12 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845 > void WebGLRenderingContextBase::initializeNewContext() test comment 15
Joey Arhar
Comment 24 2020-09-28 17:56:27 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:846 > { test comment 16
Joey Arhar
Comment 25 2020-09-28 17:57:07 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847 > + // test comment 17
Joey Arhar
Comment 26 2020-09-28 17:57:26 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:848 > + // test comment 18
Joey Arhar
Comment 27 2020-09-28 17:57:50 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849 > + // TESTING test comment 19
Joey Arhar
Comment 28 2020-09-28 17:58:04 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850 > + // test comment 20
Joey Arhar
Comment 29 2020-09-28 17:59:18 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851 > + // test comment 21
Joey Arhar
Comment 30 2020-09-28 17:59:41 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852 > + test comment 22
Joey Arhar
Comment 31 2020-09-28 17:59:58 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 > ASSERT(!m_contextLost); test comment 23
Joey Arhar
Comment 32 2020-09-28 18:00:15 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854 > m_needsUpdate = true; test comment 24
Joey Arhar
Comment 33 2020-09-28 18:01:10 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855 > m_markedCanvasDirty = false; test comment 25 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1349 > test comment 26 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350 > void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name) test comment 27 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1351 > { test comment 28
Joey Arhar
Comment 34 2020-09-28 18:03:15 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1352 > + // test comment 29
Joey Arhar
Comment 35 2020-09-29 10:01:23 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> test comment 1
Joey Arhar
Comment 36 2020-09-29 10:01:49 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:2 > + test comment 2
Joey Arhar
Comment 37 2020-09-29 10:02:20 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts test comment 3
Joey Arhar
Comment 38 2020-09-29 10:03:20 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts test comment 3
Joey Arhar
Comment 39 2020-09-29 10:04:30 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts test comment 3
Joey Arhar
Comment 40 2020-09-29 10:05:34 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review >>>> Source/WebCore/ChangeLog:3 >>>> + Test bug for code review timeouts >>> >>> test comment 3 >> >> test comment 3 > > test comment 3 test comment 3 > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 test comment 4
Joey Arhar
Comment 41 2020-09-29 10:09:27 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review >>>>> Source/WebCore/ChangeLog:3 >>>>> + Test bug for code review timeouts >>>> >>>> test comment 3 >>> >>> test comment 3 >> >> test comment 3 > > test comment 3 test comment 3
Joey Arhar
Comment 42 2020-09-29 10:13:02 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:7 > + test comment 5
Joey Arhar
Comment 43 2020-09-29 10:13:25 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. test comment 6
Joey Arhar
Comment 44 2020-09-29 10:16:27 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:10 > + * html/canvas/WebGLRenderingContextBase.cpp: test comment 7
Joey Arhar
Comment 45 2020-09-29 10:16:40 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::WebGLRenderingContextBase::initializeNewContext): test comment 8
Joey Arhar
Comment 46 2020-09-29 10:17:35 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::WebGLRenderingContextBase::createFramebuffer): test comment 9
Joey Arhar
Comment 47 2020-09-29 10:17:50 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::WebGLRenderingContextBase::drawArrays): test comment 10
Joey Arhar
Comment 48 2020-09-29 10:18:26 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::WebGLRenderingContextBase::readPixels): test comment 11
Joey Arhar
Comment 49 2020-09-29 10:19:07 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review >> Source/WebCore/ChangeLog:16 >> + (WebCore::WebGLRenderingContextBase::readPixels): > > test comment 11 test comment 11
Joey Arhar
Comment 50 2020-09-29 10:31:20 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:18 > + (WebCore::WebGLRenderingContextBase::texParameter): test comment 12
Joey Arhar
Comment 51 2020-09-29 10:31:34 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/ChangeLog:19 > + test comment 13
Joey Arhar
Comment 52 2020-09-29 10:32:30 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844 > test comment 14
Joey Arhar
Comment 53 2020-09-29 10:32:46 PDT
Comment on attachment 409932 [details] test patch View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845 > void WebGLRenderingContextBase::initializeNewContext() test comment 15
Joey Arhar
Comment 54 2020-09-29 12:05:25 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:2 > + comment 1
Joey Arhar
Comment 55 2020-09-29 12:05:46 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts comment 2
Joey Arhar
Comment 56 2020-09-29 12:06:56 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:5 > + comment 3
Joey Arhar
Comment 57 2020-09-29 12:07:12 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). comment 4
Joey Arhar
Comment 58 2020-09-29 12:07:47 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. comment 5
Joey Arhar
Comment 59 2020-09-29 12:08:35 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:10 > + * html/canvas/WebGLRenderingContextBase.cpp: comment 6
Joey Arhar
Comment 60 2020-09-29 12:08:49 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::WebGLRenderingContextBase::initializeNewContext): comment 7
Joey Arhar
Comment 61 2020-09-29 12:09:34 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::WebGLRenderingContextBase::createFramebuffer): comment 8
Joey Arhar
Comment 62 2020-09-29 12:09:50 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::WebGLRenderingContextBase::drawArrays): comment 9
Joey Arhar
Comment 63 2020-09-29 12:10:43 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::WebGLRenderingContextBase::readPixels): comment 10
Joey Arhar
Comment 64 2020-09-29 12:10:57 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::WebGLRenderingContextBase::texSubImage2DBase): comment 11
Joey Arhar
Comment 65 2020-09-29 12:11:46 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844 > comment 12
Joey Arhar
Comment 66 2020-09-29 12:12:33 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845 > void WebGLRenderingContextBase::initializeNewContext() comment 13
Joey Arhar
Comment 67 2020-09-29 12:13:17 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847 > + // comment 14
Joey Arhar
Comment 68 2020-09-29 12:14:15 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849 > + // TESTING comment 15
Joey Arhar
Comment 69 2020-09-29 12:24:40 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852 > + comment 16
Joey Arhar
Comment 70 2020-09-29 12:25:05 PDT
Comment on attachment 409933 [details] test patch upload 2 View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 > ASSERT(!m_contextLost); comment 17
Joey Arhar
Comment 71 2020-09-29 14:55:41 PDT
Comment on attachment 409934 [details] test patch upload 3 View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> comment 1
Radar WebKit Bug Importer
Comment 72 2020-10-02 21:40:18 PDT
<rdar://problem/69907701>
Joey Arhar
Comment 73 2020-10-09 20:17:09 PDT
Created attachment 411001 [details] test patch 4
Joey Arhar
Comment 74 2020-10-09 20:17:42 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> comment 1
Joey Arhar
Comment 75 2020-10-09 20:18:19 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:2 > + comment 2
Joey Arhar
Comment 76 2020-10-09 20:19:24 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts comment 3
Joey Arhar
Comment 77 2020-10-09 20:19:48 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 comment 4
Joey Arhar
Comment 78 2020-10-09 20:23:13 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:5 > + 5 > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). 6
Joey Arhar
Comment 79 2020-10-09 20:23:50 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:7 > + 7
Joey Arhar
Comment 80 2020-10-09 20:28:59 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:9 > + 9
Joey Arhar
Comment 81 2020-10-09 20:29:11 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:10 > + * html/canvas/WebGLRenderingContextBase.cpp: 10
Joey Arhar
Comment 82 2020-10-09 20:29:24 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::WebGLRenderingContextBase::initializeNewContext): 11
Joey Arhar
Comment 83 2020-10-09 20:29:42 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:12 > + (WebCore::WebGLRenderingContextBase::bindAttribLocation): 12
Joey Arhar
Comment 84 2020-10-10 12:01:10 PDT
Created attachment 411014 [details] test
Joey Arhar
Comment 85 2020-10-10 12:02:15 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> 1
Joey Arhar
Comment 86 2020-10-10 12:02:51 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:2 > + 2
Joey Arhar
Comment 87 2020-10-10 12:03:35 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts 3
Joey Arhar
Comment 88 2020-10-10 12:03:59 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 4
Joey Arhar
Comment 89 2020-10-10 12:04:17 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:5 > + 5
Joey Arhar
Comment 90 2020-10-10 12:05:58 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). 6
Joey Arhar
Comment 91 2020-10-10 12:06:14 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:7 > + 7
Joey Arhar
Comment 92 2020-10-10 12:06:58 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. 8
Joey Arhar
Comment 93 2020-10-10 12:10:38 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/ChangeLog:9 > + 9
Joey Arhar
Comment 94 2020-10-12 08:54:32 PDT
Created attachment 411121 [details] test
Joey Arhar
Comment 95 2020-10-12 08:55:30 PDT
Comment on attachment 411121 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> 1
Joey Arhar
Comment 96 2020-10-12 08:55:56 PDT
Comment on attachment 411121 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review > Source/WebCore/ChangeLog:2 > + 2
Joey Arhar
Comment 97 2020-10-12 08:56:41 PDT
Comment on attachment 411121 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts 3
Joey Arhar
Comment 98 2020-10-12 08:58:12 PDT
Comment on attachment 411121 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review >> Source/WebCore/ChangeLog:3 >> + Test bug for code review timeouts > > 3 3 > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 4
Joey Arhar
Comment 99 2020-10-12 08:59:07 PDT
Comment on attachment 411121 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review >>> Source/WebCore/ChangeLog:3 >>> + Test bug for code review timeouts >> >> 3 > > 3 3 >> Source/WebCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=217008 > > 4 4 > Source/WebCore/ChangeLog:5 > + 5
Joey Arhar
Comment 100 2020-10-13 13:29:55 PDT
Created attachment 411246 [details] test
Joey Arhar
Comment 101 2020-10-13 13:30:11 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> 1
Joey Arhar
Comment 102 2020-10-13 13:30:45 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:2 > + 2
Joey Arhar
Comment 103 2020-10-13 13:31:47 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts 3
Joey Arhar
Comment 104 2020-10-13 13:36:05 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review >> Source/WebCore/ChangeLog:3 >> + Test bug for code review timeouts > > 3 3 > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 4
Joey Arhar
Comment 105 2020-10-13 13:46:17 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:5 > + 5
Joey Arhar
Comment 106 2020-10-13 13:50:15 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). 6
Joey Arhar
Comment 107 2020-10-13 14:03:34 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:7 > + 7
Joey Arhar
Comment 108 2020-10-13 14:04:15 PDT
Comment on attachment 411246 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. 8
Joey Arhar
Comment 109 2020-10-13 15:25:24 PDT
Created attachment 411268 [details] test
Joey Arhar
Comment 110 2020-10-13 15:25:55 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> 1
Joey Arhar
Comment 111 2020-10-13 15:47:40 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/ChangeLog:2 > + 2
Joey Arhar
Comment 112 2020-10-13 15:48:57 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts 3
Joey Arhar
Comment 113 2020-10-13 15:56:28 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review >> Source/WebCore/ChangeLog:3 >> + Test bug for code review timeouts > > 3 3 > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 4
Joey Arhar
Comment 114 2020-10-13 15:57:02 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review >>> Source/WebCore/ChangeLog:3 >>> + Test bug for code review timeouts >> >> 3 > > 3 3 >> Source/WebCore/ChangeLog:4 >> + https://bugs.webkit.org/show_bug.cgi?id=217008 > > 4 4 > Source/WebCore/ChangeLog:5 > + 5
Joey Arhar
Comment 115 2020-10-13 15:58:39 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). 6
Joey Arhar
Comment 116 2020-10-13 16:00:25 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/ChangeLog:7 > + 7
Joey Arhar
Comment 117 2020-10-13 16:01:36 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. 8
Joey Arhar
Comment 118 2020-10-13 16:33:41 PDT
Created attachment 411277 [details] test
Joey Arhar
Comment 119 2020-10-13 16:34:06 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> 1
Joey Arhar
Comment 120 2020-10-13 16:36:59 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:2 > + 2
Joey Arhar
Comment 121 2020-10-13 16:37:57 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts 3
Joey Arhar
Comment 122 2020-10-13 16:38:55 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 4
Joey Arhar
Comment 123 2020-10-13 16:43:20 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:5 > + 5
Joey Arhar
Comment 124 2020-10-13 16:54:12 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). 6
Joey Arhar
Comment 125 2020-10-13 16:55:05 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/ChangeLog:7 > + 7
Joey Arhar
Comment 126 2020-10-13 17:30:23 PDT
Created attachment 411284 [details] test
Joey Arhar
Comment 127 2020-10-13 17:31:05 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:1 > +2020-09-25 Kenneth Russell <kbr@chromium.org> 1
Joey Arhar
Comment 128 2020-10-13 17:32:21 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >> Source/WebCore/ChangeLog:1 >> +2020-09-25 Kenneth Russell <kbr@chromium.org> > > 1 1 > Source/WebCore/ChangeLog:2 > + 2
Joey Arhar
Comment 129 2020-10-13 17:34:07 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:3 > + Test bug for code review timeouts 3
Joey Arhar
Comment 130 2020-10-13 17:34:26 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=217008 4
Joey Arhar
Comment 131 2020-10-13 17:35:17 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:5 > + 5
Joey Arhar
Comment 132 2020-10-13 17:35:36 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). 6
Joey Arhar
Comment 133 2020-10-13 17:36:21 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:7 > + 7
Joey Arhar
Comment 134 2020-10-13 17:36:43 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. 8
Joey Arhar
Comment 135 2020-10-13 17:37:27 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:9 > + 9
Joey Arhar
Comment 136 2020-10-13 17:38:17 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:10 > + * html/canvas/WebGLRenderingContextBase.cpp: 10
Joey Arhar
Comment 137 2020-10-13 17:38:36 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:11 > + (WebCore::WebGLRenderingContextBase::initializeNewContext): 11
Joey Arhar
Comment 138 2020-10-13 17:39:44 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:12 > + (WebCore::WebGLRenderingContextBase::bindAttribLocation): 12
Joey Arhar
Comment 139 2020-10-13 17:39:59 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::WebGLRenderingContextBase::createFramebuffer): 13
Joey Arhar
Comment 140 2020-10-13 17:40:43 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:14 > + (WebCore::WebGLRenderingContextBase::drawArrays): 14
Joey Arhar
Comment 141 2020-10-13 17:41:01 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::WebGLRenderingContextBase::getUniformLocation): 15
Joey Arhar
Comment 142 2020-10-13 17:41:44 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:16 > + (WebCore::WebGLRenderingContextBase::readPixels): 16
Joey Arhar
Comment 143 2020-10-13 17:42:32 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:17 > + (WebCore::WebGLRenderingContextBase::texSubImage2DBase): 17
Joey Arhar
Comment 144 2020-10-13 17:43:15 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:18 > + (WebCore::WebGLRenderingContextBase::texParameter): 18
Joey Arhar
Comment 145 2020-10-13 17:43:34 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:19 > + 19
Joey Arhar
Comment 146 2020-10-13 17:44:14 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:20 > 2020-09-23 Chris Dumez <cdumez@apple.com> 20
Joey Arhar
Comment 147 2020-10-13 17:44:35 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:21 > 21
Joey Arhar
Comment 148 2020-10-13 17:45:20 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/ChangeLog:22 > webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing 22
Joey Arhar
Comment 149 2020-10-13 17:46:08 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844 > 23
Joey Arhar
Comment 150 2020-10-13 17:47:38 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845 > void WebGLRenderingContextBase::initializeNewContext() 24
Joey Arhar
Comment 151 2020-10-13 17:47:56 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:846 > { 25
Joey Arhar
Comment 152 2020-10-13 17:48:32 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847 > + // 26
Joey Arhar
Comment 153 2020-10-13 17:48:47 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:848 > + // 27
Joey Arhar
Comment 154 2020-10-13 17:49:20 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849 > + // TESTING 28
Joey Arhar
Comment 155 2020-10-13 19:37:03 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850 > + // 29
Joey Arhar
Comment 156 2020-10-13 19:38:19 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850 >> + // > > 29 29 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851 > + // 30
Richard Townsend
Comment 157 2020-10-14 02:46:22 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 158 2020-10-14 02:47:56 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 159 2020-10-14 02:48:37 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 160 2020-10-14 02:59:12 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 161 2020-10-14 03:12:51 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 162 2020-10-14 03:45:58 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 163 2020-10-14 03:49:07 PDT
Comment on attachment 411284 [details] test Testing
Joey Arhar
Comment 164 2020-10-14 10:17:59 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850 >>> + // >> >> 29 > > 29 29 >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851 >> + // > > 30 30 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852 > + 31
Joey Arhar
Comment 165 2020-10-14 10:18:23 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 > ASSERT(!m_contextLost); 32
Joey Arhar
Comment 166 2020-10-14 10:33:37 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 >> ASSERT(!m_contextLost); > > 32 32 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854 > m_needsUpdate = true; 33 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855 > m_markedCanvasDirty = false; 34
Joey Arhar
Comment 167 2020-10-14 12:06:19 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 >>> ASSERT(!m_contextLost); >> >> 32 > > 32 32 >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854 >> m_needsUpdate = true; > > 33 33 >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855 >> m_markedCanvasDirty = false; > > 34 34 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1349 > 35
Joey Arhar
Comment 168 2020-10-14 12:11:12 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350 > void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name) 36
Joey Arhar
Comment 169 2020-10-15 14:59:25 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1351 > { 37
Joey Arhar
Comment 170 2020-10-15 15:00:17 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1352 > + // 38
Joey Arhar
Comment 171 2020-10-15 15:02:53 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353 > + // 39
Joey Arhar
Comment 172 2020-10-15 17:33:35 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353 >> + // > > 39 39 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354 > + // TESTING 40
Joey Arhar
Comment 173 2020-10-15 17:36:01 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353 >>> + // >> >> 39 > > 39 39 >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354 >> + // TESTING > > 40 40 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355 > + // 41
Joey Arhar
Comment 174 2020-10-15 17:37:21 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353 >>>> + // >>> >>> 39 >> >> 39 > > 39 39 >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354 >>> + // TESTING >> >> 40 > > 40 40 >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355 >> + // > > 41 41 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356 > + // 42
Joey Arhar
Comment 175 2020-10-15 17:38:12 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1357 > + 43
Richard Townsend
Comment 176 2020-10-19 17:03:24 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review Testing >>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354 >>>> + // TESTING >>> >>> 40 >> >> 40 > > 40 Testing > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208 > + // Testing
Richard Townsend
Comment 177 2020-10-19 17:07:08 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review TEsting >> Source/WebCore/ChangeLog:17 >> + (WebCore::WebGLRenderingContextBase::texSubImage2DBase): > > 17 Testing >>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354 >>>>> + // TESTING >>>> >>>> 40 >>> >>> 40 >> >> 40 > > Testing Testing >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208 >> + // > > Testing Testing
Joey Arhar
Comment 178 2020-10-19 18:37:15 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1358 > if (isContextLostOrPending() || !validateWebGLProgramOrShader("bindAttribLocation", &program)) 44
Richard Townsend
Comment 179 2020-10-20 08:06:04 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review TEsting >>> Source/WebCore/ChangeLog:17 >>> + (WebCore::WebGLRenderingContextBase::texSubImage2DBase): >> >> 17 > > Testing Testing >>>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354 >>>>>> + // TESTING >>>>> >>>>> 40 >>>> >>>> 40 >>> >>> 40 >> >> Testing > > Testing Testing >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355 >>> + // >> >> 41 > > 41 Testing >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208 >>> + // >> >> Testing > > Testing Testing
Richard Townsend
Comment 180 2020-10-20 08:43:35 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1359 > return; Testing.
Richard Townsend
Comment 181 2020-10-20 08:46:15 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2558 > + // Testing
Richard Townsend
Comment 182 2020-10-20 08:47:23 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 > ASSERT(!m_contextLost); Test
Richard Townsend
Comment 183 2020-10-20 08:52:42 PDT
Comment on attachment 411001 [details] test patch 4 View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review > Source/WebCore/ChangeLog:18 > + (WebCore::WebGLRenderingContextBase::texParameter): Testing
Richard Townsend
Comment 184 2020-10-20 08:53:16 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review Testing > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4209 > + Testing
Richard Townsend
Comment 185 2020-10-20 08:54:03 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review Testing. >>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355 >>>> + // >>> >>> 41 >> >> 41 > > Testing Testing.
Richard Townsend
Comment 186 2020-10-20 08:59:53 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855 >>> m_markedCanvasDirty = false; >> >> 34 > > 34 Testing
Richard Townsend
Comment 187 2020-10-20 09:01:10 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849 > + // TESTING testing >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 >> ASSERT(!m_contextLost); > > Test c
Richard Townsend
Comment 188 2020-10-20 09:06:48 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851 > + // Testing
Richard Townsend
Comment 189 2020-10-20 09:07:14 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 >>> ASSERT(!m_contextLost); >> >> Test > > c Testing
Richard Townsend
Comment 190 2020-10-20 09:08:29 PDT
Comment on attachment 411014 [details] test Testing
Richard Townsend
Comment 191 2020-10-20 09:09:42 PDT
Comment on attachment 411268 [details] test Testing
Richard Townsend
Comment 192 2020-10-20 09:15:23 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 193 2020-10-20 09:16:21 PDT
Comment on attachment 409932 [details] test patch Testing
Richard Townsend
Comment 194 2020-10-20 09:27:28 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207 > + // Testing
Richard Townsend
Comment 195 2020-10-20 09:27:35 PDT
View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207 > + // Testing
Richard Townsend
Comment 196 2020-10-20 09:28:46 PDT
Comment on attachment 411268 [details] test Something
Richard Townsend
Comment 197 2020-10-20 09:30:31 PDT
Comment on attachment 409934 [details] test patch upload 3 Testing
Richard Townsend
Comment 198 2020-10-20 09:33:47 PDT
Comment on attachment 409934 [details] test patch upload 3 View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852 > + Testing
Richard Townsend
Comment 199 2020-10-20 09:35:15 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review Testing > Source/WebCore/ChangeLog:16 > + (WebCore::WebGLRenderingContextBase::readPixels): Testing > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2554 > + // Tetsting
Richard Townsend
Comment 200 2020-10-20 09:57:06 PDT
Comment on attachment 411284 [details] test asdf
Richard Townsend
Comment 201 2020-10-20 10:09:05 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207 > + // Testing
Richard Townsend
Comment 202 2020-10-20 10:22:19 PDT
Comment on attachment 411284 [details] test asdfasdf
Richard Townsend
Comment 203 2020-10-20 10:23:13 PDT
Comment on attachment 411284 [details] test Testing
Richard Townsend
Comment 204 2020-10-20 10:26:26 PDT
Comment on attachment 409934 [details] test patch upload 3 View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review Testing > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356 > + // Testing
Richard Townsend
Comment 205 2020-10-20 10:27:51 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1961 > + Testing
Richard Townsend
Comment 206 2020-10-20 10:33:05 PDT
Comment on attachment 409933 [details] test patch upload 2 Testing
Richard Townsend
Comment 207 2020-10-20 10:35:40 PDT
Comment on attachment 409933 [details] test patch upload 2 Testing
Richard Townsend
Comment 208 2020-10-20 10:41:43 PDT
Comment on attachment 411268 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review Test > Source/WebCore/ChangeLog:21 > Test
Richard Townsend
Comment 209 2020-10-20 10:53:03 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853 >>>> ASSERT(!m_contextLost); >>> >>> 32 >> >> 32 > > 32 Testing
Richard Townsend
Comment 210 2020-10-20 10:57:11 PDT
Comment on attachment 409932 [details] test patch Testing
Richard Townsend
Comment 211 2020-10-20 10:57:43 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review Testing >> Source/WebCore/ChangeLog:16 >> + (WebCore::WebGLRenderingContextBase::readPixels): > > 16 Testing
Richard Townsend
Comment 212 2020-10-20 10:58:57 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review Testing > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5065 > + // Testing
Richard Townsend
Comment 213 2020-10-20 11:49:45 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851 >>> + // >> >> 30 > > 30 Testing
Richard Townsend
Comment 214 2020-10-21 11:24:43 PDT
Comment on attachment 411277 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356 > + // Testing
Richard Townsend
Comment 215 2020-10-21 11:25:53 PDT
Comment on attachment 411121 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1960 > + // Testing
Richard Townsend
Comment 216 2020-10-21 15:20:38 PDT
Comment on attachment 411014 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850 > + // Testing
Joey Arhar
Comment 217 2020-10-22 15:55:30 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review >> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350 >> void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name) > > 36 36 > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1359 > return; 45
Joey Arhar
Comment 218 2020-10-22 15:57:38 PDT
Comment on attachment 411284 [details] test View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1360 > if (!validateLocationLength("bindAttribLocation", name)) 46
Mason Freed
Comment 219 2020-10-28 15:41:56 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review test > Source/WebCore/ChangeLog:8 > + No-op changes to have a place for code reviews. testing 123
Mason Freed
Comment 220 2020-10-28 17:18:32 PDT
Comment on attachment 409897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review test >> Source/WebCore/ChangeLog:8 >> + No-op changes to have a place for code reviews. > > testing 123 testing 123 > Source/WebCore/ChangeLog:9 > + testing again
Note You need to log in before you can comment on or make changes to this bug.