Bug 216976

Summary: [LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in WebCore::Layout::FormattingContext::Geometry::computedHeightValue
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description zalan 2020-09-25 08:25:59 PDT
ssia
Comment 1 zalan 2020-09-25 08:31:31 PDT
Created attachment 409697 [details]
Patch
Comment 2 Antti Koivisto 2020-09-25 08:33:05 PDT
Comment on attachment 409697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409697&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:-1177
> -    // FIXME: Find out if min/max-height properties should also be taken into account here.

I guess we found out!
Comment 3 zalan 2020-09-25 08:39:51 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 409697 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409697&action=review
> 
> > Source/WebCore/layout/FormattingContextGeometry.cpp:-1177
> > -    // FIXME: Find out if min/max-height properties should also be taken into account here.
> 
> I guess we found out!
Most certainly we did!
Comment 4 EWS 2020-09-25 09:05:48 PDT
Committed r267572: <https://trac.webkit.org/changeset/267572>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409697 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-25 09:06:18 PDT
<rdar://problem/69574883>