Bug 216966

Summary: [JSC] Introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION to make host function definition easy-to-scanned for JIT-caging
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, ashvayka, beidson, benjamin, calvaris, cdumez, cmarcelo, ews-watchlist, hi, joepeck, jsbell, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
saam: review+, ews-feeder: commit-queue-
Patch none

Description Yusuke Suzuki 2020-09-25 01:20:39 PDT 
[JSC] Introduce JSC_DECLARE_HOST_FUNCTION / JSC_DEFINE_HOST_FUNCTION to make host function definition easy-to-scanned for JIT-caging
Comment 1 Yusuke Suzuki 2020-09-25 01:26:39 PDT 
Created attachment 409666 [details]
Patch
Comment 2 Yusuke Suzuki 2020-09-25 01:38:14 PDT 
Created attachment 409667 [details]
Patch
Comment 3 Yusuke Suzuki 2020-09-25 01:47:43 PDT 
Created attachment 409668 [details]
Patch
Comment 4 Saam Barati 2020-09-25 06:24:44 PDT 
Comment on attachment 409668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409668&action=review

> Source/WTF/wtf/PlatformCallingConventions.h:49
> +#define JSC_ANNOTATE_HOST_FUNCTION(functionId, function)

This will do something in the future?
Comment 5 Yusuke Suzuki 2020-09-25 12:21:31 PDT 
(In reply to Saam Barati from comment #4)
> Comment on attachment 409668 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409668&action=review
> 
> > Source/WTF/wtf/PlatformCallingConventions.h:49
> > +#define JSC_ANNOTATE_HOST_FUNCTION(functionId, function)
> 
> This will do something in the future?

Yes
Comment 6 Yusuke Suzuki 2020-09-25 12:22:27 PDT 
Created attachment 409719 [details]
Patch
Comment 7 Yusuke Suzuki 2020-09-25 14:23:54 PDT 
stress/put-private-name-invalid-define.js.ftl-eager is flaky before this patch. Landing this now.
Comment 8 Yusuke Suzuki 2020-09-25 14:32:32 PDT 
Committed r267594: <https://trac.webkit.org/changeset/267594>
Comment 9 Radar WebKit Bug Importer 2020-09-25 14:33:22 PDT 
<rdar://problem/69594503>
Comment 10 Alexey Shvayka 2020-09-26 14:52:19 PDT 
Comment on attachment 409719 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409719&action=review

> Source/JavaScriptCore/ChangeLog:199


It would be nice to tweak ChangeLog generation tool so the host function names are displayed correctly.