Bug 216961

Summary: REGRESSION (r267227): imported/w3c/web-platform-tests/xhr/event-timeout.any.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, darin, dpino, ews-watchlist, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=216266
https://github.com/web-platform-tests/wpt/pull/27034
Attachments:
Description Flags
Patch none

Description Ryan Haddad 2020-09-24 22:44:56 PDT 
imported/w3c/web-platform-tests/xhr/event-timeout.any.html is frequently failing on iOS simulator and macOS debug wk2 bots:

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout.any-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout.any-actual.txt
@@ -1,3 +1,3 @@
 
-PASS XMLHttpRequest: timeout event 
+FAIL XMLHttpRequest: timeout event assert_unreached: ontimeout not called. Reached unreachable code
 
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fevent-timeout.any.html
Comment 1 Radar WebKit Bug Importer 2020-09-24 22:46:08 PDT 
<rdar://problem/69548545>
Comment 3 youenn fablet 2021-01-04 05:20:10 PST 
Created attachment 416934 [details]
Patch
Comment 4 EWS Watchlist 2021-01-04 05:20:48 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 5 youenn fablet 2021-01-04 05:20:56 PST 
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/27034
Comment 6 Darin Adler 2021-01-05 13:29:22 PST 
Comment on attachment 416934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416934&action=review

> LayoutTests/imported/w3c/web-platform-tests/xhr/event-timeout.any.js:17
> -  }, 10);
> +  }, 1000);

Will this be upstreamed?
Comment 7 youenn fablet 2021-01-06 00:44:12 PST 
(In reply to Darin Adler from comment #6)
> Comment on attachment 416934 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416934&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/xhr/event-timeout.any.js:17
> > -  }, 10);
> > +  }, 1000);
> 
> Will this be upstreamed?

Yes, webkit-patch upload did it for me at https://github.com/web-platform-tests/wpt/pull/27034.
Now that it is r+ed, I will merge this WPT PR before landing this change.
Comment 8 EWS 2021-01-06 01:12:42 PST 
Committed r271196: <https://trac.webkit.org/changeset/271196>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416934 [details].