Bug 216959

Summary: [webkitperl] Check for custom Flatpak user dirs in webkitdirs.pm
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, jbedard, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Lauro Moura 2020-09-24 21:59:11 PDT
[webkitperl] Check for custom Flatpak user dirs in webkitdirs.pm
Comment 1 Lauro Moura 2020-09-24 21:59:56 PDT
Created attachment 409655 [details]
Patch
Comment 2 Philippe Normand 2020-09-25 00:41:08 PDT
Comment on attachment 409655 [details]
Patch

What is the reason for this change?
Comment 3 Lauro Moura 2020-09-25 04:56:38 PDT
(In reply to Philippe Normand from comment #2)
> Comment on attachment 409655 [details]
> Patch
> 
> What is the reason for this change?

I had setup a new worktree with no previous UserFlatpak, only UserFlatpak.Local from a custom SDK build, exported through WEBKIT_FLATPAK_USER_DIR.

The current build-webkit (throught getUserFlatpakPath) did not try to check for the WEBKIT_FLATPAK_USER_DIR and called cmake directly instead from inside flatpak.
Comment 4 EWS 2020-09-25 07:17:57 PDT
Committed r267567: <https://trac.webkit.org/changeset/267567>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409655 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-25 07:18:19 PDT
<rdar://problem/69569686>