| Summary: | [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2020-09-24 20:55:30 PDT
Created attachment 409653 [details]
Patch
Comment on attachment 409653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409653&action=review > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37 > + , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height()) Argument order is confusing because FloatRect(float x, float y, float width, float height) (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409653 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409653&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37 > > + , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height()) > > Argument order is confusing because FloatRect(float x, float y, float > width, float height) Yeah, in layout I started using top, left, width, height. I might change it later. Committed r267557: <https://trac.webkit.org/changeset/267557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409653 [details]. |