| Summary: | REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | All | ||||||||||||
| OS: | All | ||||||||||||
| Attachments: |
|
||||||||||||
TabBrowser.js:407
this._navigationSidebar.addSidebarPanel(navigationSidebarPanel);
this._navigationSidebar._sidebarPanels is [] here.
Created attachment 409617 [details]
Patch
Created attachment 409618 [details]
[Video] With patch applied
Comment on attachment 409617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409617&action=review r=me with some copyediting > Source/WebInspectorUI/UserInterface/Views/Sidebar.js:75 > + console.assert(!(sidebarPanel.parentSidebar && sidebarPanel.parentSidebar !== this), "sidebarPanel already has a different parentSidebar", sidebarPanel); The assertion message seems incorrect, it could assert if sidebarPanel.parentSidebar is falsy as well. How about a simpler message "Failed to insert sidebar panel". We'd be able to infer which condition failed from looking at the `sidebarPanel` argument, so a more specific message is unnecessary. Created attachment 409620 [details]
Patch
Committed r267546: <https://trac.webkit.org/changeset/267546> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409620 [details]. |
Created attachment 409615 [details] [Image] Bug Steps: 1. Select Sources tab 2. Select Elements tab 3. Select Sources tab Expected: Sources navigation sidebar shouldn't be empty on step 1 or 3.