Bug 216942

Summary: REGRESSION(r267379): Web Inspector: Sources navigation sidebar is empty every other time it's selected
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, ews-watchlist, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Image] Bug
none
Patch
bburg: review+, bburg: commit-queue-
[Video] With patch applied
none
Patch none

Nikita Vasilyev
Reported 2020-09-24 12:57:41 PDT
Created attachment 409615 [details] [Image] Bug Steps: 1. Select Sources tab 2. Select Elements tab 3. Select Sources tab Expected: Sources navigation sidebar shouldn't be empty on step 1 or 3.
Attachments
[Image] Bug (379.22 KB, image/png)
2020-09-24 12:57 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.72 KB, patch)
2020-09-24 13:30 PDT, Nikita Vasilyev 		bburg: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
[Video] With patch applied (7.74 MB, video/quicktime)
2020-09-24 13:37 PDT, Nikita Vasilyev 		no flags
Details
Patch (1.72 KB, patch)
2020-09-24 14:10 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-09-24 12:58:06 PDT
<rdar://problem/69520398>
Nikita Vasilyev
Comment 2 2020-09-24 13:08:42 PDT
TabBrowser.js:407 this._navigationSidebar.addSidebarPanel(navigationSidebarPanel); this._navigationSidebar._sidebarPanels is [] here.
Nikita Vasilyev
Comment 3 2020-09-24 13:30:09 PDT
Created attachment 409617 [details] Patch
Nikita Vasilyev
Comment 4 2020-09-24 13:37:21 PDT
Created attachment 409618 [details] [Video] With patch applied
Blaze Burg
Comment 5 2020-09-24 14:02:16 PDT
Comment on attachment 409617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409617&action=review r=me with some copyediting > Source/WebInspectorUI/UserInterface/Views/Sidebar.js:75 > + console.assert(!(sidebarPanel.parentSidebar && sidebarPanel.parentSidebar !== this), "sidebarPanel already has a different parentSidebar", sidebarPanel); The assertion message seems incorrect, it could assert if sidebarPanel.parentSidebar is falsy as well. How about a simpler message "Failed to insert sidebar panel". We'd be able to infer which condition failed from looking at the `sidebarPanel` argument, so a more specific message is unnecessary.
Nikita Vasilyev
Comment 6 2020-09-24 14:10:31 PDT
Created attachment 409620 [details] Patch
EWS
Comment 7 2020-09-24 14:47:49 PDT
Committed r267546: <https://trac.webkit.org/changeset/267546> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409620 [details].
Note You need to log in before you can comment on or make changes to this bug.