Bug 216939

Summary: Use more inline initialization and constexpr in WebAudio code
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web AudioAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 212611    
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-09-24 12:06:55 PDT
Use more inline initialization and constexpr in WebAudio code.
Comment 1 Chris Dumez 2020-09-24 12:11:23 PDT
Created attachment 409610 [details]
Patch
Comment 2 Darin Adler 2020-09-24 12:24:44 PDT
Comment on attachment 409610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409610&action=review

> Source/WebCore/platform/audio/HRTFPanner.h:85
> +    int m_azimuthIndex1 { UninitializedAzimuth };

Maybe these become optionals too?

> Source/WebCore/platform/audio/HRTFPanner.h:89
> +    int m_azimuthIndex2 { UninitializedAzimuth };

Maybe these become optionals too?
Comment 3 Chris Dumez 2020-09-24 12:31:54 PDT
Created attachment 409612 [details]
Patch
Comment 4 EWS 2020-09-24 13:10:11 PDT
Committed r267544: <https://trac.webkit.org/changeset/267544>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409612 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-24 13:11:16 PDT
<rdar://problem/69521117>