Bug 216928

Summary: [LFC][Integration] Enable on Apple Windows port
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, bfulgham, cdumez, changseok, cmarcelo, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, pdr, ryuan.choi, sam, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 216914    
Attachments:
Description Flags
wip
none
patch
none
test
ews-feeder: commit-queue-
patch
none
patch
none
patch none

Description Antti Koivisto 2020-09-24 05:12:00 PDT
For consistency.
Comment 1 Antti Koivisto 2020-09-24 05:13:21 PDT
Created attachment 409562 [details]
wip
Comment 2 Antti Koivisto 2020-09-24 07:36:59 PDT
Created attachment 409573 [details]
patch
Comment 3 Sam Weinig 2020-09-24 07:40:17 PDT
Comment on attachment 409573 [details]
patch

Any reason we can't just enable this everywhere at this point and remove the #ifdef?
Comment 4 Antti Koivisto 2020-09-24 07:51:03 PDT
> Any reason we can't just enable this everywhere at this point and remove the
> #ifdef?

Not really.
Comment 5 EWS 2020-09-24 08:52:50 PDT
Committed r267533: <https://trac.webkit.org/changeset/267533>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409573 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-24 08:53:19 PDT
<rdar://problem/69505961>
Comment 7 Antti Koivisto 2020-09-25 00:16:38 PDT
This didn't go right.
Comment 8 Antti Koivisto 2020-09-25 00:28:18 PDT
Created attachment 409662 [details]
test
Comment 9 Antti Koivisto 2020-09-25 02:15:53 PDT
Created attachment 409671 [details]
patch
Comment 10 Antti Koivisto 2020-09-25 02:18:53 PDT
Created attachment 409672 [details]
patch
Comment 11 Antti Koivisto 2020-09-25 02:32:00 PDT
Created attachment 409673 [details]
patch
Comment 12 EWS 2020-09-25 04:24:32 PDT
Committed r267562: <https://trac.webkit.org/changeset/267562>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409673 [details].