Bug 216923

Summary: REGRESSION(r267507): Broke two layout tests on windows
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, cdumez, darin, mjs, ryanhaddad, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 214932    
Attachments:
Description Flags
REVERT of r267507 none

Description WebKit Commit Bot 2020-09-24 04:48:01 PDT 
https://trac.webkit.org/changeset/267507 broke the build:
Broke two layout tests on windows

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2020-09-24 04:48:07 PDT 
Created attachment 409554 [details]
REVERT of r267507

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the revert will be successful.  This process takes approximately 15 minutes.

If you would like to land the revert faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 EWS 2020-09-24 04:49:41 PDT 
Committed r267525: <https://trac.webkit.org/changeset/267525>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409554 [details].
Comment 3 Radar WebKit Bug Importer 2020-09-24 04:50:19 PDT 
<rdar://problem/69495517>
Comment 4 Chris Dumez 2020-09-24 08:00:23 PDT 
Windows does not support WebAudio. Skipping the tests was the way to go.
Comment 5 Aakash Jain 2020-09-28 07:42:46 PDT 
Yeah, the tests should have been skipped in the patch before landing. EWS did indicate the failure (in https://ews-build.webkit.org/#/builders/10/builds/37108).

It's not a good idea to land failing tests, expecting bot-watcher to take care of them. Landing failing tests also slows down our infra-structure for everyone.
Comment 6 Chris Dumez 2020-09-28 07:57:23 PDT 
(In reply to Aakash Jain from comment #5)
> Yeah, the tests should have been skipped in the patch before landing. EWS
> did indicate the failure (in
> https://ews-build.webkit.org/#/builders/10/builds/37108).
> 
> It's not a good idea to land failing tests, expecting bot-watcher to take
> care of them. Landing failing tests also slows down our infra-structure for
> everyone.

This is obviously not what I did. The win EWS likely had not processed the patch yet when I cq+. I don’t knowingly commit broken tests. I do I initiate the cq before all EWS is done though if some of the ews is slow and if the mac ews bubble is green. We all have to stay productive.