Bug 216901

Summary: Add feature flags for GPU Process features
Product: WebKit Reporter: Peng Liu <peng.liu6>
Component: New BugsAssignee: Peng Liu <peng.liu6>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, eric.carlson, ews-watchlist, glenn, jer.noble, mmaxfield, philipj, sabouhallawa, sergio, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Peng Liu 2020-09-23 15:44:00 PDT 
We need to add Feature Flags for the following GPU Process features:
1. 2D canvas in GPU process
2. WebGL in GPU process
3. DOM rendering in GPU Process
Comment 1 Peng Liu 2020-09-23 15:44:28 PDT 
<rdar://69454005>
Comment 2 Peng Liu 2020-09-23 16:20:17 PDT 
Created attachment 409514 [details]
Patch
Comment 3 Tim Horton 2020-09-23 16:33:23 PDT 
Comment on attachment 409514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409514&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3787
> +    // FIXME: useGPUProcessForMediaEnabled should be a RuntimeEnabledFeature since it's global.

lies
Comment 4 Tim Horton 2020-09-23 16:35:20 PDT 
Comment on attachment 409514 [details]
Patch

I'm not totally sold on the "use X enabled" grammar, but it seems like we were split before so at least making them consistent is good.
Comment 5 Peng Liu 2020-09-23 16:53:14 PDT 
(In reply to Tim Horton from comment #4)
> Comment on attachment 409514 [details]
> Patch
> 
> I'm not totally sold on the "use X enabled" grammar, but it seems like we
> were split before so at least making them consistent is good.

Agree. We need to update all of them together someday.
Comment 6 EWS 2020-09-23 20:36:53 PDT 
Committed r267516: <https://trac.webkit.org/changeset/267516>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409514 [details].