| Summary: | [build.webkit.org] Add unit-test to detect invalid triggers in config.json | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, jbedard, ryanhaddad, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=216658 | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2020-09-23 14:40:38 PDT
This is to prevent issues like https://bugs.webkit.org/show_bug.cgi?id=216658#c15 Turns out that we don't have any unit-test for build.webkit.org for testing config.json Created attachment 409994 [details]
Patch
(In reply to Aakash Jain from comment #3) > Created attachment 409994 [details] > Patch This is mostly copied from https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/ews-build/loadConfig_unittest.py Long term aim is to have almost same unit-tests testing both EWS and build.webkit.org, but that would need various changes (especially because of different Buildbot versions) and would be done incrementally. Created attachment 409996 [details]
Patch
Committed r267736: <https://trac.webkit.org/changeset/267736> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409996 [details]. |