| Summary: | [LFC][IFC] Precompute the collapsible trailing width for LineBreaker | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
zalan
2020-09-23 08:29:34 PDT
Created attachment 409477 [details]
Patch
Comment on attachment 409477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409477&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:240 > + if (isFullyCollapsible()) > + m_collapsibleTrailingWidth += logicalWidth; > + else { Can this early return avoiding the else branch? Created attachment 409493 [details]
Patch
(In reply to Antti Koivisto from comment #2) > Comment on attachment 409477 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409477&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:240 > > + if (isFullyCollapsible()) > > + m_collapsibleTrailingWidth += logicalWidth; > > + else { > > Can this early return avoiding the else branch? absolutely! Committed r267494: <https://trac.webkit.org/changeset/267494> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409493 [details]. |