| Summary: | Root node with stateless wheel event is not always canHandleWheelEvent | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | cathiechen <cathiechen> | ||||||
| Component: | Scrolling | Assignee: | cathiechen <cathiechen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, simon.fraser, tonikitoo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=216609 | ||||||||
| Attachments: |
|
||||||||
|
Description
cathiechen
2020-09-23 06:12:23 PDT
Created attachment 409468 [details]
Patch
Comment on attachment 409468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148 > + if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone))) This should use isNonGestureEvent() Comment on attachment 409468 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409468&action=review >> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:148 >> + if (isLatchedNode() || (isRootNode() && !(wheelEvent.phase() == PlatformWheelEventPhaseNone && wheelEvent.momentumPhase() == PlatformWheelEventPhaseNone))) > > This should use isNonGestureEvent() Done, thanks! Created attachment 409540 [details]
Patch
Committed r267527: <https://trac.webkit.org/changeset/267527> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409540 [details]. |