| Summary: | Add CSSConditionRule and CSSGroupingRule | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
| Component: | New Bugs | Assignee: | Darin Adler <darin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | annulen, bfulgham, cdumez, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, keith_miller, kondapallykalyan, macpherson, menard, philipj, ryuan.choi, sam, sergio, simon.fraser, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 216940 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Darin Adler
2020-09-22 15:52:58 PDT
Created attachment 409425 [details]
Patch
Created attachment 409430 [details]
Patch
Created attachment 409597 [details]
Patch
Comment on attachment 409597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review > Source/WebCore/css/CSSConditionRule.h:18 > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Library General Public > + * License as published by the Free Software Foundation; either > + * version 2 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Library General Public License for more details. > + * > + * You should have received a copy of the GNU Library General Public License > + * along with this library; see the file COPYING.LIB. If not, write to > + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, > + * Boston, MA 02110-1301, USA. > + */ You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD. Comment on attachment 409597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review >> Source/WebCore/css/CSSConditionRule.h:18 >> + */ > > You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD. Oops, will fix that. Sorry, copied from the wrong header. Comment on attachment 409597 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review >>> Source/WebCore/css/CSSConditionRule.h:18 >>> + */ >> >> You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD. > > Oops, will fix that. Sorry, copied from the wrong header. I think I used the correct one above in CSSConditionRule.cpp and that’s what I’ll use on all the new files. Tests passing, need review. I have fixed the licenses in my local copy. Committed r267576: <https://trac.webkit.org/changeset/267576> *** Bug 200838 has been marked as a duplicate of this bug. *** |